[Backport ncs-v3.4-branch] Cherry pick nrf spim rtio #15755
compliance.yml
on: pull_request
Run compliance checks on patch series (PR)
3m 48s
Annotations
1 warning and 10 notices
|
Run compliance checks on patch series (PR):
ClangFormat.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- ret = spi_nrfx_spim_common_transfer_start(dev,
- tx_buf,
- tx_buf_len,
- rx_buf,
- rx_buf_len);
+ ret = spi_nrfx_spim_common_transfer_start(dev, tx_buf, tx_buf_len, rx_buf, rx_buf_len);
File:drivers/spi/spi_nrfx_spim.c
Line:76
You may want to run clang-format on this change:
-static int driver_api_transceive(const struct device *dev,
- const struct spi_config *spi_cfg,
+static int driver_api_transceive(const struct device *dev, const struct spi_config *spi_cfg,
File:drivers/spi/spi_nrfx_spim.c
Line:164
You may want to run clang-format on this change:
-static int driver_api_transceive_async(const struct device *dev,
- const struct spi_config *spi_cfg,
+static int driver_api_transceive_async(const struct device *dev, const struct spi_config *spi_cfg,
const struct spi_buf_set *tx_bufs,
- const struct spi_buf_set *rx_bufs,
- spi_callback_t cb,
+ const struct spi_buf_set *rx_bufs, spi_callback_t cb,
void *userdata)
{
return transceive(dev, spi_cfg, tx_bufs, rx_bufs, true, cb, userdata);
}
#endif
-static int driver_api_release(const struct device *dev,
- const struct spi_config *spi_cfg)
+static int driver_api_release(const struct device *dev, const struct spi_config *spi_cfg)
File:drivers/spi/spi_nrfx_spim.c
Line:184
You may want to run clang-format on this change:
-#define DRIVER_DEFINE(inst) \
- static struct driver_data CONCAT(data, inst) = { \
- .common = SPI_NRFX_COMMON_DATA_INIT(inst), \
+#define DRIVER_DEFINE(inst) \
+ static struct driver_data CONCAT(data, inst) = { \
+ .common = SPI_NRFX_COMMON_DATA_INIT(inst), \
IF_ENABLED( \
CONFIG_MULTITHREADING, \
(SPI_CONTEXT_INIT_LOCK(CONCAT(data, inst), ctx),) \
- ) \
- IF_ENABLED( \
+ ) \
+ IF_ENABLED( \
CONFIG_MULTITHREADING, \
(SPI_CONTEXT_INIT_SYNC(CONCAT(data, inst), ctx),) \
- ) \
- }; \
- \
- SPI_NRFX_COMMON_DEFINE(inst, &CONCAT(data, inst)); \
- \
- static const struct driver_config CONCAT(config, inst) = { \
- .common = SPI_NRFX_COMMON_CONFIG_INIT( \
- inst, \
- spim_evt_handler \
- ), \
- }; \
- \
- PM_DEVICE_DT_INST_DEFINE(inst, spi_nrfx_spim_common_pm_action, 1); \
- \
- SPI_DEVICE_DT_INST_DEINIT_DEFINE( \
- inst, \
- driver_init, \
- driver_deinit, \
- PM_DEVICE_DT_INST_GET(inst), \
- &CONCAT(data, inst), \
- &CONCAT(config, inst), \
- POST_KERNEL, \
- CONFIG_SPI_INIT_PRIORITY, \
- &driver_api \
- )
+ ) }; \
+ \
+ SPI_NRFX_COMMON_DEFINE(inst, &CONCAT(data, inst)); \
+ \
+ static const struct driver_config CONCAT(config, inst) = { \
+ .common = SPI_NRFX_COMMON_CONFIG_INIT(inst, spim_evt_handler), \
+ }; \
+ \
+ PM_DEVICE_DT_INST_DEFINE(inst, spi_nrfx_spim_common_pm_action, 1); \
+ \
+ SPI_DEVICE_DT_INST_DEINIT_DEFINE(inst, driver_init, driver_deinit, \
+ PM_DEVICE_DT_INST_GET(inst),
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim_common.c#L222
drivers/spi/spi_nrfx_spim_common.c:222
-static int prepare_rx_ram_buf(const struct device *dev,
- uint8_t **rx_buf,
- size_t rx_buf_len)
+static int prepare_rx_ram_buf(const struct device *dev, uint8_t **rx_buf, size_t rx_buf_len)
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim_common.c#L201
drivers/spi/spi_nrfx_spim_common.c:201
-static int prepare_tx_ram_buf(const struct device *dev,
- const uint8_t **tx_buf,
- size_t tx_buf_len)
+static int prepare_tx_ram_buf(const struct device *dev, const uint8_t **tx_buf, size_t tx_buf_len)
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim_common.c#L166
drivers/spi/spi_nrfx_spim_common.c:166
- if (frequency > MHZ(16) &&
- nrf_clock_hfclk_div_get(NRF_CLOCK) != NRF_CLOCK_HFCLK_DIV_1) {
+ if (frequency > MHZ(16) && nrf_clock_hfclk_div_get(NRF_CLOCK) != NRF_CLOCK_HFCLK_DIV_1) {
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim_common.c#L123
drivers/spi/spi_nrfx_spim_common.c:123
- if (a->frequency != b->frequency ||
- a->operation != b->operation ||
- a->slave != b->slave ||
- a->cs.cs_is_gpio != b->cs.cs_is_gpio ||
- a->word_delay != b->word_delay) {
+ if (a->frequency != b->frequency || a->operation != b->operation || a->slave != b->slave ||
+ a->cs.cs_is_gpio != b->cs.cs_is_gpio || a->word_delay != b->word_delay) {
return false;
}
if (a->cs.cs_is_gpio) {
- if (a->cs.gpio.port != b->cs.gpio.port ||
- a->cs.gpio.pin != b->cs.gpio.pin ||
- a->cs.gpio.dt_flags != b->cs.gpio.dt_flags ||
- a->cs.delay != b->cs.delay) {
+ if (a->cs.gpio.port != b->cs.gpio.port || a->cs.gpio.pin != b->cs.gpio.pin ||
+ a->cs.gpio.dt_flags != b->cs.gpio.dt_flags || a->cs.delay != b->cs.delay) {
return false;
}
} else {
- if (a->cs.setup_ns != b->cs.setup_ns ||
- a->cs.hold_ns != b->cs.hold_ns) {
+ if (a->cs.setup_ns != b->cs.setup_ns || a->cs.hold_ns != b->cs.hold_ns) {
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim_common.c#L34
drivers/spi/spi_nrfx_spim_common.c:34
- k_timer_start(&dev_data->wake_timer,
- K_USEC(CONFIG_SPI_NRFX_WAKE_TIMEOUT_US),
- K_FOREVER);
+ k_timer_start(&dev_data->wake_timer, K_USEC(CONFIG_SPI_NRFX_WAKE_TIMEOUT_US), K_FOREVER);
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim_common.c#L19
drivers/spi/spi_nrfx_spim_common.c:19
-#define WAKE_PIN_STOP_FLAGS (GPIO_INPUT | GPIO_PULL_DOWN | GPIO_DISCONNECTED)
+#define WAKE_PIN_STOP_FLAGS (GPIO_INPUT | GPIO_PULL_DOWN | GPIO_DISCONNECTED)
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim.c#L265
drivers/spi/spi_nrfx_spim.c:265
-#define DRIVER_DEFINE(inst) \
- static struct driver_data CONCAT(data, inst) = { \
- .common = SPI_NRFX_COMMON_DATA_INIT(inst), \
+#define DRIVER_DEFINE(inst) \
+ static struct driver_data CONCAT(data, inst) = { \
+ .common = SPI_NRFX_COMMON_DATA_INIT(inst), \
IF_ENABLED( \
CONFIG_MULTITHREADING, \
(SPI_CONTEXT_INIT_LOCK(CONCAT(data, inst), ctx),) \
- ) \
- IF_ENABLED( \
+ ) \
+ IF_ENABLED( \
CONFIG_MULTITHREADING, \
(SPI_CONTEXT_INIT_SYNC(CONCAT(data, inst), ctx),) \
- ) \
- }; \
- \
- SPI_NRFX_COMMON_DEFINE(inst, &CONCAT(data, inst)); \
- \
- static const struct driver_config CONCAT(config, inst) = { \
- .common = SPI_NRFX_COMMON_CONFIG_INIT( \
- inst, \
- spim_evt_handler \
- ), \
- }; \
- \
- PM_DEVICE_DT_INST_DEFINE(inst, spi_nrfx_spim_common_pm_action, 1); \
- \
- SPI_DEVICE_DT_INST_DEINIT_DEFINE( \
- inst, \
- driver_init, \
- driver_deinit, \
- PM_DEVICE_DT_INST_GET(inst), \
- &CONCAT(data, inst), \
- &CONCAT(config, inst), \
- POST_KERNEL, \
- CONFIG_SPI_INIT_PRIORITY, \
- &driver_api \
- )
+ ) }; \
+ \
+ SPI_NRFX_COMMON_DEFINE(inst, &CONCAT(data, inst)); \
+ \
+ static const struct driver_config CONCAT(config, inst) = { \
+ .common = SPI_NRFX_COMMON_CONFIG_INIT(inst, spim_evt_handler), \
+ }; \
+ \
+ PM_DEVICE_DT_INST_DEFINE(inst, spi_nrfx_spim_common_pm_action, 1); \
+ \
+ SPI_DEVICE_DT_INST_DEINIT_DEFINE(inst, driver_init, driver_deinit, \
+ PM_DEVICE_DT_INST_GET(inst), &CONCAT(data, inst), \
+ &CONCAT(config, inst), POST_KERNEL, \
+ CONFIG_SPI_INIT_PRIORITY, &driver_api)
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim.c#L184
drivers/spi/spi_nrfx_spim.c:184
-static int driver_api_transceive_async(const struct device *dev,
- const struct spi_config *spi_cfg,
+static int driver_api_transceive_async(const struct device *dev, const struct spi_config *spi_cfg,
const struct spi_buf_set *tx_bufs,
- const struct spi_buf_set *rx_bufs,
- spi_callback_t cb,
+ const struct spi_buf_set *rx_bufs, spi_callback_t cb,
void *userdata)
{
return transceive(dev, spi_cfg, tx_bufs, rx_bufs, true, cb, userdata);
}
#endif
-static int driver_api_release(const struct device *dev,
- const struct spi_config *spi_cfg)
+static int driver_api_release(const struct device *dev, const struct spi_config *spi_cfg)
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim.c#L164
drivers/spi/spi_nrfx_spim.c:164
-static int driver_api_transceive(const struct device *dev,
- const struct spi_config *spi_cfg,
+static int driver_api_transceive(const struct device *dev, const struct spi_config *spi_cfg,
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
|
You may want to run clang-format on this change:
drivers/spi/spi_nrfx_spim.c#L76
drivers/spi/spi_nrfx_spim.c:76
- ret = spi_nrfx_spim_common_transfer_start(dev,
- tx_buf,
- tx_buf_len,
- rx_buf,
- rx_buf_len);
+ ret = spi_nrfx_spim_common_transfer_start(dev, tx_buf, tx_buf_len, rx_buf, rx_buf_len);
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
compliance.xml
|
5.42 KB |
sha256:7018aae21a5a46557b448113f940cec19ab5c9d69a3107e76604bda54a606a81
|
|
|
dts_linter.patch
|
148 Bytes |
sha256:084526f640177f0d3df2eba95fd6682b81b25b5582fc83267d3e987d85ab1b4c
|
|