Skip to content

Commit 29f3cba

Browse files
ananglcvinayak
authored andcommitted
[nrf fromtree] drivers: pinctrl_nrf: Configure QSPI IO3 pin as output set high
... so that the pin is kept in a defined state when the IO3 line is not controlled by the QSPI peripheral (when the peripheral is disabled or disconnected from the pin). The IO3 pin in Quad SPI flash chips usually has dual functionality - it is an I/O line when the chip is configured to work in Quad (4 I/O) mode and it is a HOLD# or RESET# line when the chip is configured to work in non-Quad (2 I/O) mode. In the latter case, it is important that the line is kept in the inactive (high) state, otherwise communication with the chip may be disrupted (and this actually happens when e.g. the spi_flash sample is used on a brand new nRF5340 or nRF52840 DK - the nrf_qspi_nor driver fails to initialize and the sample just ends up with the "mx25r6435f@0: device not ready" message). This commit addresses the problem in the same way that it was done for the CSN line in commit 6d8172f. Signed-off-by: Andrzej Głąbek <[email protected]> (cherry picked from commit 2f44266)
1 parent 8d8503f commit 29f3cba

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/pinctrl/pinctrl_nrf.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,8 @@ int pinctrl_configure_pins(const pinctrl_soc_pin_t *pins, uint8_t pin_cnt,
312312
break;
313313
case NRF_FUN_QSPI_IO3:
314314
NRF_PSEL_QSPI(reg, IO3) = psel;
315-
dir = NRF_GPIO_PIN_DIR_INPUT;
315+
write = 1U;
316+
dir = NRF_GPIO_PIN_DIR_OUTPUT;
316317
input = NRF_GPIO_PIN_INPUT_DISCONNECT;
317318
break;
318319
#endif /* defined(NRF_PSEL_QSPI) */

0 commit comments

Comments
 (0)