add maxWarnings option to eslint plugins inferred lint task

[jgannonjr]

When using the eslint plugin's inferred task, there's no way to set the maxWarnings option (or other options).

The relevant code block is:

nx/packages/eslint/src/plugins/plugin.ts

Lines 462 to 525 in 5feafd6

	function buildEslintTargets(
	eslintConfigs: string[],
	eslintVersion: string,
	projectRoot: string,
	workspaceRoot: string,
	options: EslintPluginOptions,
	standaloneSrcPath?: string
	) {
	const isRootProject = projectRoot === '.';
	const targets: Record<string, TargetConfiguration> = {};
	const targetConfig: TargetConfiguration = {
	command: `eslint ${
	isRootProject && standaloneSrcPath ? `./${standaloneSrcPath}` : '.'
	}`,
	cache: true,
	options: {
	cwd: projectRoot,
	},
	inputs: [
	'default',
	// Certain lint rules can be impacted by changes to dependencies
	'^default',
	...eslintConfigs.map((config) =>
	`{workspaceRoot}/${config}`.replace(
	`{workspaceRoot}/${projectRoot}`,
	isRootProject ? '{projectRoot}/' : '{projectRoot}'
	)
	),
	...(existsSync(join(workspaceRoot, projectRoot, '.eslintignore'))
	? ['{projectRoot}/.eslintignore']
	: []),
	'{workspaceRoot}/tools/eslint-rules/**/*',
	{ externalDependencies: ['eslint'] },
	],
	outputs: ['{options.outputFile}'],
	metadata: {
	technologies: ['eslint'],
	description: 'Runs ESLint on project',
	help: {
	command: `${pmc.exec} eslint --help`,
	example: {
	options: {
	'max-warnings': 0,
	},
	},
	},
	},
	};
	// Always set the environment variable to ensure that the ESLint CLI can run on eslint v8 and v9
	const useFlatConfig = eslintConfigs.some((config) => isFlatConfig(config));
	// Flat config is default for 9.0.0+
	const defaultSetting = gte(eslintVersion, '9.0.0');
	if (useFlatConfig !== defaultSetting) {
	targetConfig.options.env = {
	ESLINT_USE_FLAT_CONFIG: useFlatConfig ? 'true' : 'false',
	};
	}
	targets[options.targetName] = targetConfig;
	return targets;
	}

The inferred target TargetConfiguration is using a eslint 'command', it seems that it would make more sense to use the @nx/eslint:lint 'executor'. This would be my proposed solution. That way the targetDefaults can be set in nx.json for @nx/eslint:lint, and this can be used to set the maxWarnings as well as other configuration options for the executor.

An alternative solution would be adding a plugin configuration option to set this and continue using the 'command', but this seems less ideal since these options are already supported in the executor.