Skip to content

Commit fc12f7f

Browse files
committed
refactor: split api management models into domain & dto
1 parent 3cb9528 commit fc12f7f

41 files changed

Lines changed: 469 additions & 215 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

modules/api/api-management/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,9 @@ openApiGenerate {
4141

4242
additionalProperties.put("apiNamePrefix", "ManagementRest")
4343
additionalProperties.put("apiNameSuffix", "")
44+
additionalProperties.put("modelNameSuffix", "Dto")
4445
additionalProperties.put("apiPackage", "kasanari.catalog.management.api")
45-
additionalProperties.put("modelPackage", "kasanari.catalog.management.model")
46+
additionalProperties.put("modelPackage", "kasanari.catalog.management.dto")
4647
additionalProperties.put("dateLibrary", "java8")
4748
}
4849

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
package kasanari.catalog.management.dto;
2+
3+
public enum CatalogModeDto {
4+
INTERNAL("INTERNAL"),
5+
PROXY("PROXY");
6+
7+
private final String value;
8+
9+
CatalogModeDto(String value) {
10+
this.value = value;
11+
}
12+
13+
public static CatalogModeDto fromValue(String value) {
14+
for (var item : values()) {
15+
if (item.value.equals(value)) {
16+
return item;
17+
}
18+
}
19+
throw new IllegalArgumentException("Unknown catalog mode: " + value);
20+
}
21+
22+
@Override
23+
public String toString() {
24+
return value;
25+
}
26+
}

modules/api/api-management/src/main/java/kasanari/catalog/management/model/CatalogPublicInfo.java renamed to modules/api/api-management/src/main/java/kasanari/catalog/management/dto/CatalogPublicInfoDto.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
package kasanari.catalog.management.model;
1+
package kasanari.catalog.management.dto;
22

3-
public class CatalogPublicInfo {
3+
public class CatalogPublicInfoDto {
44
private String catalogId;
5-
private CatalogType catalogType;
6-
private CatalogMode mode;
7-
private CatalogSpec spec;
5+
private CatalogTypeDto catalogType;
6+
private CatalogModeDto mode;
7+
private CatalogSpecDto spec;
88
private Long version;
99

1010
public String getCatalogId() {
@@ -15,27 +15,27 @@ public void setCatalogId(String catalogId) {
1515
this.catalogId = catalogId;
1616
}
1717

18-
public CatalogType getCatalogType() {
18+
public CatalogTypeDto getCatalogType() {
1919
return catalogType;
2020
}
2121

22-
public void setCatalogType(CatalogType catalogType) {
22+
public void setCatalogType(CatalogTypeDto catalogType) {
2323
this.catalogType = catalogType;
2424
}
2525

26-
public CatalogMode getMode() {
26+
public CatalogModeDto getMode() {
2727
return mode;
2828
}
2929

30-
public void setMode(CatalogMode mode) {
30+
public void setMode(CatalogModeDto mode) {
3131
this.mode = mode;
3232
}
3333

34-
public CatalogSpec getSpec() {
34+
public CatalogSpecDto getSpec() {
3535
return spec;
3636
}
3737

38-
public void setSpec(CatalogSpec spec) {
38+
public void setSpec(CatalogSpecDto spec) {
3939
this.spec = spec;
4040
}
4141

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
package kasanari.catalog.management.dto;
2+
3+
4+
public class CatalogSpecDto {
5+
private CatalogTypeDto type;
6+
private IcebergCatalogSpecModeConfigDto modeConfig;
7+
8+
public CatalogTypeDto getType() {
9+
return type;
10+
}
11+
12+
public void setType(CatalogTypeDto type) {
13+
this.type = type;
14+
}
15+
16+
public IcebergCatalogSpecModeConfigDto getModeConfig() {
17+
return modeConfig;
18+
}
19+
20+
public void setModeConfig(IcebergCatalogSpecModeConfigDto modeConfig) {
21+
this.modeConfig = modeConfig;
22+
}
23+
}
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
package kasanari.catalog.management.dto;
2+
3+
public enum CatalogTypeDto {
4+
ICEBERG("ICEBERG"),
5+
PAIMON("PAIMON"),
6+
LANCE("LANCE");
7+
8+
private final String value;
9+
10+
CatalogTypeDto(String value) {
11+
this.value = value;
12+
}
13+
14+
public static CatalogTypeDto fromValue(String value) {
15+
for (var item : values()) {
16+
if (item.value.equals(value)) {
17+
return item;
18+
}
19+
}
20+
throw new IllegalArgumentException("Unknown catalog type: " + value);
21+
}
22+
23+
@Override
24+
public String toString() {
25+
return value;
26+
}
27+
}
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
package kasanari.catalog.management.dto;
2+
3+
public class CreateCatalogRequestDto {
4+
private String catalogId;
5+
private CatalogTypeDto catalogType;
6+
private CatalogModeDto mode;
7+
private CatalogSpecDto spec;
8+
9+
public String getCatalogId() {
10+
return catalogId;
11+
}
12+
13+
public void setCatalogId(String catalogId) {
14+
this.catalogId = catalogId;
15+
}
16+
17+
public CatalogTypeDto getCatalogType() {
18+
return catalogType;
19+
}
20+
21+
public void setCatalogType(CatalogTypeDto catalogType) {
22+
this.catalogType = catalogType;
23+
}
24+
25+
public CatalogModeDto getMode() {
26+
return mode;
27+
}
28+
29+
public void setMode(CatalogModeDto mode) {
30+
this.mode = mode;
31+
}
32+
33+
public CatalogSpecDto getSpec() {
34+
return spec;
35+
}
36+
37+
public void setSpec(CatalogSpecDto spec) {
38+
this.spec = spec;
39+
}
40+
}
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package kasanari.catalog.management.dto;
2+
3+
import java.util.ArrayList;
4+
import java.util.List;
5+
6+
public class DeleteRolesRequestDto {
7+
private List<RoleBindingDto> bindings = new ArrayList<>();
8+
9+
public List<RoleBindingDto> getBindings() {
10+
return bindings;
11+
}
12+
13+
public void setBindings(List<RoleBindingDto> bindings) {
14+
this.bindings = bindings;
15+
}
16+
}

modules/api/api-management/src/main/java/kasanari/catalog/management/model/ErrorResponse.java renamed to modules/api/api-management/src/main/java/kasanari/catalog/management/dto/ErrorResponseDto.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
package kasanari.catalog.management.model;
1+
package kasanari.catalog.management.dto;
22

3-
public class ErrorResponse {
3+
public class ErrorResponseDto {
44
private String message;
55

66
public String getMessage() {
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package kasanari.catalog.management.dto;
2+
3+
import java.util.ArrayList;
4+
import java.util.List;
5+
6+
public class GetRolesResponseDto {
7+
private List<RoleBindingDto> bindings = new ArrayList<>();
8+
9+
public List<RoleBindingDto> getBindings() {
10+
return bindings;
11+
}
12+
13+
public void setBindings(List<RoleBindingDto> bindings) {
14+
this.bindings = bindings;
15+
}
16+
}

modules/api/api-management/src/main/java/kasanari/catalog/management/model/IcebergCatalogSpecModeConfig.java renamed to modules/api/api-management/src/main/java/kasanari/catalog/management/dto/IcebergCatalogSpecModeConfigDto.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package kasanari.catalog.management.model;
1+
package kasanari.catalog.management.dto;
22

33
import java.util.HashMap;
44
import java.util.Map;
55

6-
public class IcebergCatalogSpecModeConfig {
6+
public class IcebergCatalogSpecModeConfigDto {
77
private Map<String, String> properties = new HashMap<>();
88
private String endpoint;
99

0 commit comments

Comments
 (0)