Merge pull request #364 from ns1-terraform/fix/zone-networks-empty-array

fix zone creation with empty networks field

Author: arnavbhattacharya-NS1

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.7.3 (November 25, 2025)
+BUGFIX
+* Fix zone create with empty networks field
+
 ## 2.7.2 (October 21, 2025)
 BUGFIX
 * Headers were not added to webhook notifiers

go.mod

@@ -7,7 +7,7 @@ require (
 	github.com/hashicorp/go-retryablehttp v0.7.7
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.24.1
 	github.com/stretchr/testify v1.8.1
-	gopkg.in/ns1/ns1-go.v2 v2.15.1
+	gopkg.in/ns1/ns1-go.v2 v2.15.2
 )
 
 require (

go.sum

@@ -257,8 +257,8 @@ gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8
 gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
 gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
-gopkg.in/ns1/ns1-go.v2 v2.15.1 h1:8rri2TzAPYcVbBGXn48+dz1Xg30PzHfZ4k8A9JOS0Z0=
-gopkg.in/ns1/ns1-go.v2 v2.15.1/go.mod h1:pfaU0vECVP7DIOr453z03HXS6dFJpXdNRwOyRzwmPSc=
+gopkg.in/ns1/ns1-go.v2 v2.15.2 h1:aBVyKeEH3rBFWwX72xPPjEuRL4+Lp5P9GlAcrzu0Y5M=
+gopkg.in/ns1/ns1-go.v2 v2.15.2/go.mod h1:pfaU0vECVP7DIOr453z03HXS6dFJpXdNRwOyRzwmPSc=
 gopkg.in/warnings.v0 v0.1.2 h1:wFXVbFY8DY5/xOe1ECiWdKCzZlxgshcYVNkBHstARME=
 gopkg.in/warnings.v0 v0.1.2/go.mod h1:jksf8JmL6Qr/oQM2OXTHunEvvTAsrWBLb6OOjuVWRNI=
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=

ns1/config.go

@@ -19,7 +19,7 @@ import (
 )
 
 var (
-	clientVersion     = "2.7.2"
+	clientVersion     = "2.7.3"
 	providerUserAgent = "tf-ns1" + "/" + clientVersion
 	defaultRetryMax   = 3
 )

ns1/resource_zone.go

@@ -391,7 +391,7 @@ func resourceDataToZone(z *dns.Zone, d *schema.ResourceData) {
 	if v, ok := d.GetOk("link"); ok {
 		z.LinkTo(v.(string))
 	}
-	if v, ok := d.GetOk("networks"); ok {
+	if v, ok := d.GetOkExists("networks"); ok {
 		networkIDSet := v.(*schema.Set)
 		z.NetworkIDs = setToInts(networkIDSet)
 	}

ns1/resource_zone_test.go

@@ -506,6 +506,144 @@ func TestAccZone_ManualDelete(t *testing.T) {
 	})
 }
 
+func TestAccZone_Networks(t *testing.T) {
+	var zone dns.Zone
+	zoneName := fmt.Sprintf("terraform-test-%s.io",
+		acctest.RandStringFromCharSet(15, acctest.CharSetAlphaNum),
+	)
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckZoneDestroy,
+		Steps: []resource.TestStep{
+			// Create with nil networks (field omitted) - should default to [0]
+			{
+				Config: testAccZoneDefaultNetworks(zoneName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckZoneExists("ns1_zone.it", &zone),
+					testAccCheckZoneNetworks(&zone, []int{0}, "initial create with nil networks"),
+				),
+			},
+			// Update with nil networks (no change) - should remain [0]
+			{
+				Config: testAccZoneDefaultNetworks(zoneName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckZoneExists("ns1_zone.it", &zone),
+					testAccCheckZoneNetworks(&zone, []int{0}, "update with nil networks"),
+				),
+			},
+			// Update with empty networks [] - should become []
+			{
+				Config: testAccZoneEmptyNetworks(zoneName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckZoneExists("ns1_zone.it", &zone),
+					testAccCheckZoneNetworks(&zone, []int{}, "update with networks=[]"),
+				),
+			},
+			// Update back to nil networks - should become [0]
+			{
+				Config: testAccZoneDefaultNetworks(zoneName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckZoneExists("ns1_zone.it", &zone),
+					testAccCheckZoneNetworks(&zone, []int{0}, "update back to nil networks"),
+				),
+			},
+			// Update with specific networks [1, 2]
+			{
+				Config: testAccZoneSpecificNetworks(zoneName, []int{1, 2}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckZoneExists("ns1_zone.it", &zone),
+					testAccCheckZoneNetworks(&zone, []int{1, 2}, "update with networks=[1,2]"),
+				),
+			},
+			// Import verification
+			{
+				ResourceName:      "ns1_zone.it",
+				ImportState:       true,
+				ImportStateId:     zoneName,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
+func TestAccZone_CreateWithEmptyNetworks(t *testing.T) {
+	var zone dns.Zone
+	zoneName := fmt.Sprintf("terraform-test-%s.io",
+		acctest.RandStringFromCharSet(15, acctest.CharSetAlphaNum),
+	)
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckZoneDestroy,
+		Steps: []resource.TestStep{
+			// Create with empty networks [] - should be []
+			{
+				Config: testAccZoneEmptyNetworks(zoneName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckZoneExists("ns1_zone.it", &zone),
+					testAccCheckZoneNetworks(&zone, []int{}, "create with networks=[]"),
+				),
+			},
+			// Update to specific networks
+			{
+				Config: testAccZoneSpecificNetworks(zoneName, []int{1}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckZoneExists("ns1_zone.it", &zone),
+					testAccCheckZoneNetworks(&zone, []int{1}, "update to networks=[1]"),
+				),
+			},
+			// Update back to empty networks []
+			{
+				Config: testAccZoneEmptyNetworks(zoneName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckZoneExists("ns1_zone.it", &zone),
+					testAccCheckZoneNetworks(&zone, []int{}, "update back to networks=[]"),
+				),
+			},
+			// Import verification
+			{
+				ResourceName:      "ns1_zone.it",
+				ImportState:       true,
+				ImportStateId:     zoneName,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
+func testAccZoneEmptyNetworks(zoneName string) string {
+	return fmt.Sprintf(`resource "ns1_zone" "it" {
+    zone="%s"
+    networks=[]
+}
+`, zoneName)
+}
+
+func testAccZoneSpecificNetworks(zoneName string, networks []int) string {
+	networksStr := "["
+	for i, n := range networks {
+		if i > 0 {
+			networksStr += ", "
+		}
+		networksStr += fmt.Sprintf("%d", n)
+	}
+	networksStr += "]"
+
+	return fmt.Sprintf(`resource "ns1_zone" "it" {
+    zone="%s"
+    networks=%s
+}
+`, zoneName, networksStr)
+}
+
+func testAccZoneDefaultNetworks(zoneName string) string {
+	return fmt.Sprintf(`resource "ns1_zone" "it" {
+    zone="%s"
+}
+`, zoneName)
+}
+
 // A Client instance we can use outside of a TestStep
 func sharedClient() (*ns1.Client, error) {
 	var ignoreSSL bool
@@ -809,6 +947,21 @@ func testAccCheckZoneNotPrimary(z *dns.Zone) resource.TestCheckFunc {
 	}
 }
 
+func testAccCheckZoneNetworks(zone *dns.Zone, expected []int, context string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		var actual []int
+		if zone.NetworkIDs != nil {
+			actual = zone.NetworkIDs
+		}
+
+		if !reflect.DeepEqual(actual, expected) {
+			return fmt.Errorf("Networks check failed for %s: got: %v, want: %v",
+				context, actual, expected)
+		}
+		return nil
+	}
+}
+
 func testAccCheckZoneNotSecondary(z *dns.Zone) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		if z.Secondary != nil {