Skip to content

Commit 430d504

Browse files
committed
fix: address Copilot PR review
- .mcp.json: playwright-test config path apps/web -> apps/tanstack (apps/web removed earlier in dev, MCP server couldn't start) - AGENTS.md: pnpm format command description matches the new `biome check --write .` script; add `pnpm ci` line - globals.css: restore !important on Radix scroll-lock overrides (biome --unsafe stripped them but they're semantically required to override Radix's inline styles); silence noImportantStyles via biome-ignore-all - server.test.ts: rename misleading 'GET /rpc/planet/list' (the helper sends POST) to 'POST /rpc/planet/list' Skipped Copilot's suggestion to scope pnpm filters as `@nn-stack/tanstack` — pnpm matches unscoped names against the package.json `name` suffix, the current `--filter tanstack` works.
1 parent 8571e6f commit 430d504

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

.mcp.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"playwright",
1111
"run-test-mcp-server",
1212
"--config",
13-
"apps/web/playwright.config.ts"
13+
"apps/tanstack/playwright.config.ts"
1414
]
1515
}
1616
}

AGENTS.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ pnpm typecheck # tsc --noEmit across all workspaces
3030
pnpm test # vitest (server integration tests)
3131
pnpm test:e2e # playwright E2E (auto-starts dev server)
3232
pnpm lint # biome lint
33-
pnpm format # biome format --write
33+
pnpm format # biome check --write . (lint + format + import-sort)
34+
pnpm ci # biome ci (read-only, used in CI)
3435
```
3536

3637
## Documentation

apps/server/tests/server.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('Server smoke test', () => {
2121
expect(await res.text()).toBe('Hello nn stack server!');
2222
});
2323

24-
it('GET /rpc/planet/list returns 8 planets', async () => {
24+
it('POST /rpc/planet/list returns 8 planets', async () => {
2525
const { status, body } = await rpc('planet.list');
2626
expect(status).toBe(200);
2727
const planets = body as Array<{ name: string }>;

apps/tanstack/src/styles/globals.css

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ body {
1515
text-rendering: optimizeLegibility;
1616
}
1717

18+
/* biome-ignore-all lint/complexity/noImportantStyles: required to override Radix's inline scroll-lock styles */
1819
html body[data-scroll-locked] {
19-
--removed-body-scroll-bar-size: 0;
20-
margin-right: 0;
21-
overflow: visible;
20+
--removed-body-scroll-bar-size: 0 !important;
21+
margin-right: 0 !important;
22+
overflow: visible !important;
2223
}

0 commit comments

Comments
 (0)