fix: address review feedback

- rename fetchBranch to fetchAndTrackBranch to reflect that it also
  creates the local branch and sets upstream tracking
- relabel the attach-side error to "Failed to fetch/track branch" so a
  failure during the tracking step isn't mis-reported as a fetch failure
- shorten redundant "note: PR lookup failed — skipping PR lookup" to
  "note: PR lookup failed — skipping"

Author: nshen

packages/cli/src/commands/worktree/attach.ts

@@ -4,7 +4,7 @@ import { getPrForBranch } from '../../lib/gh.js'
 import {
   addWorktreeExisting,
   branchExists,
-  fetchBranch,
+  fetchAndTrackBranch,
   listWorktrees,
   remoteBranchExists,
 } from '../../lib/git.js'
@@ -74,13 +74,13 @@ export async function attachCommand(
         process.exit(1)
       }
       try {
-        await fetchBranch('origin', branch)
+        await fetchAndTrackBranch('origin', branch)
       } catch (err) {
         const stderr =
           err && typeof err === 'object' && 'stderr' in err
             ? String(err.stderr).trim()
             : String(err)
-        console.error(`Failed to fetch branch: ${stderr}`)
+        console.error(`Failed to fetch/track branch: ${stderr}`)
         process.exit(1)
       }
     }
@@ -115,7 +115,7 @@ export async function attachCommand(
       prNumber = lookup.pr
     } else if (!opts.printPath) {
       if (lookup.kind === 'unavailable') {
-        console.log('note: PR lookup failed — skipping PR lookup')
+        console.log('note: PR lookup failed — skipping')
       } else {
         console.log(`note: no open PR found for "${branch}"`)
       }

packages/cli/src/lib/git.ts

@@ -124,7 +124,7 @@ export async function remoteBranchExists(
   return out.length > 0
 }
 
-export async function fetchBranch(remote: string, branch: string) {
+export async function fetchAndTrackBranch(remote: string, branch: string) {
   const root = await getRepoRoot()
   // Plain `git fetch <remote> <branch>` uses the configured refspec and updates
   // refs/remotes/<remote>/<branch>; an explicit `<branch>:<branch>` refspec