Initialize internal plugin systems in the provider rather than in the swing app

Author: nathanielsherry

LibPeakaboo/src/main/java/org/peakaboo/tier/BasicTierProvider.java

@@ -8,6 +8,10 @@
 import org.peakaboo.controller.plotter.PlotController;
 import org.peakaboo.controller.plotter.calibration.BasicCalibrationController;
 import org.peakaboo.controller.plotter.calibration.CalibrationController;
+import org.peakaboo.controller.plotter.view.mode.ChannelViewModeRegistry;
+import org.peakaboo.curvefit.curve.fitting.fitter.CurveFitterRegistry;
+import org.peakaboo.curvefit.curve.fitting.solver.FittingSolverRegistry;
+import org.peakaboo.curvefit.peak.fitting.FittingFunctionRegistry;
 import org.peakaboo.dataset.sink.plugin.DataSinkRegistry;
 import org.peakaboo.dataset.source.model.components.scandata.analysis.Analysis;
 import org.peakaboo.dataset.source.model.components.scandata.analysis.DataSourceAnalysis;
@@ -34,6 +38,13 @@ public CalibrationController createPlotCalibrationController(PlotController plot
 
 	@Override
 	public void initializePlugins(File pluginsRoot) {
+		// Informal registries: built-in-only impls (no external JAR plugins).
+		// init() is idempotent (null-guarded), so re-entry is safe.
+		CurveFitterRegistry.init();
+		FittingSolverRegistry.init();
+		ChannelViewModeRegistry.init();
+		FittingFunctionRegistry.init();
+
 		DataSourceRegistry.init(pluginsRoot);
 		DataSinkRegistry.init(pluginsRoot);
 		FilterRegistry.init(pluginsRoot);

SwingUI/src/main/java/org/peakaboo/ui/swing/Peakaboo.java

@@ -29,10 +29,6 @@
 import org.peakaboo.app.Settings;
 import org.peakaboo.app.Version;
 import org.peakaboo.app.Version.ReleaseType;
-import org.peakaboo.controller.plotter.view.mode.ChannelViewModeRegistry;
-import org.peakaboo.curvefit.curve.fitting.fitter.CurveFitterRegistry;
-import org.peakaboo.curvefit.curve.fitting.solver.FittingSolverRegistry;
-import org.peakaboo.curvefit.peak.fitting.FittingFunctionRegistry;
 import org.peakaboo.curvefit.peak.table.PeakTable;
 import org.peakaboo.framework.accent.Mutable;
 import org.peakaboo.framework.accent.log.OneLog;
@@ -326,16 +322,8 @@ private static void initPeakTable() {
 	}
 
 	private static void initPluginSystem() {
-		// Initialize "informal" plugin registries. We use the registry format
-		// to manage different impls, but they are not a public extension point
-		// supporting external JAR plugins.
-		CurveFitterRegistry.init();
-		FittingSolverRegistry.init();
-		ChannelViewModeRegistry.init();
-		FittingFunctionRegistry.init();
-
-		// Initialize "real" plugin registries. These do support loading external
-		// JAR plugins, so we instruct them to load plugins from the given directory.
+		// Initialize the plugin system: informal built-in-only registries plus the
+		// external-JAR registries loaded from the given directory.
 		Tier.provider().initializePlugins(DesktopApp.appDir("Plugins"));
 	}