Skip to content

Commit 9759d4f

Browse files
committed
fix(ci): give each redis cluster node its own data directory
1 parent 29a1b7a commit 9759d4f

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/tests.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,15 @@ jobs:
111111
sudo apt-get install -y --fix-missing redis-server
112112
sudo service redis-server stop
113113
114+
# Every node needs its own data directory. Sharing one means sharing a
115+
# single `appendonlydir`, and three servers creating that AOF manifest
116+
# at the same time is enough to make one of them die on startup.
114117
for port in 7000 7001 7002; do
115-
redis-server --daemonize yes --port "$port" --appendonly yes --cluster-enabled yes --cluster-config-file "nodes-$port.conf"
118+
mkdir -p "$RUNNER_TEMP/redis-$port"
119+
redis-server --daemonize yes --port "$port" --appendonly yes --cluster-enabled yes \
120+
--cluster-config-file "nodes-$port.conf" \
121+
--dir "$RUNNER_TEMP/redis-$port" \
122+
--logfile "$RUNNER_TEMP/redis-$port/redis.log"
116123
done
117124
118125
# --daemonize returns as soon as the parent forks, before the node
@@ -127,7 +134,8 @@ jobs:
127134
sleep 1
128135
done
129136
130-
echo "Redis node on port $port never started accepting connections."
137+
echo "Redis node on port $port never started accepting connections. Its log:"
138+
cat "$RUNNER_TEMP/redis-$port/redis.log" || true
131139
exit 1
132140
done
133141

0 commit comments

Comments
 (0)