style(tui): clarify active panel

Author: nsumbadze

pkg/gui/keybindings_test.go

@@ -21,11 +21,23 @@ func TestOptionsMapToString(t *testing.T) {
 }
 
 func TestFormatPanelTitle(t *testing.T) {
-	actual := formatPanelTitle(2, "Packages")
-	expected := "2 Packages"
+	testCases := []struct {
+		name     string
+		focused  bool
+		expected string
+	}{
+		{name: "focused", focused: true, expected: "> 2 Packages"},
+		{name: "unfocused", focused: false, expected: "  2 Packages"},
+	}
 
-	if actual != expected {
-		t.Fatalf("formatPanelTitle() = %q, want %q", actual, expected)
+	for _, testCase := range testCases {
+		testCase := testCase
+		t.Run(testCase.name, func(t *testing.T) {
+			actual := formatPanelTitle(2, "Packages", testCase.focused)
+			if actual != testCase.expected {
+				t.Fatalf("formatPanelTitle() = %q, want %q", actual, testCase.expected)
+			}
+		})
 	}
 }
 

pkg/gui/layout.go

@@ -236,7 +236,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 		if err.Error() != "unknown view" {
 			return err
 		}
-		v.Title = formatPanelTitle(1, gui.Tr.SLocalize("StatusTitle"))
+		v.Title = gui.panelTitle("status", 1, gui.Tr.SLocalize("StatusTitle"))
 		v.FgColor = textColor
 	}
 
@@ -246,7 +246,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 			return err
 		}
 		packagesView.Highlight = true
-		packagesView.Title = formatPanelTitle(2, gui.Tr.SLocalize("PackagesTitle"))
+		packagesView.Title = gui.panelTitle("packages", 2, gui.Tr.SLocalize("PackagesTitle"))
 		packagesView.ContainsList = true
 	}
 
@@ -255,7 +255,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 		if err.Error() != "unknown view" {
 			return err
 		}
-		depsView.Title = formatPanelTitle(3, gui.Tr.SLocalize("DepsTitle"))
+		depsView.Title = gui.panelTitle("deps", 3, gui.Tr.SLocalize("DepsTitle"))
 		depsView.FgColor = textColor
 		depsView.ContainsList = true
 	}
@@ -265,7 +265,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 		if err.Error() != "unknown view" {
 			return err
 		}
-		scriptsView.Title = formatPanelTitle(4, gui.Tr.SLocalize("ScriptsTitle"))
+		scriptsView.Title = gui.panelTitle("scripts", 4, gui.Tr.SLocalize("ScriptsTitle"))
 		scriptsView.FgColor = textColor
 		scriptsView.ContainsList = true
 	}
@@ -275,7 +275,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 		if err.Error() != "unknown view" {
 			return err
 		}
-		tarballsView.Title = formatPanelTitle(5, gui.Tr.SLocalize("TarballsTitle"))
+		tarballsView.Title = gui.panelTitle("tarballs", 5, gui.Tr.SLocalize("TarballsTitle"))
 		tarballsView.FgColor = textColor
 		tarballsView.ContainsList = true
 	}

pkg/gui/view_helpers.go

@@ -206,8 +206,21 @@ func (gui *Gui) optionsMapToString(optionsMap map[string]string) string {
 	return strings.Join(optionsArray, "  •  ")
 }
 
-func formatPanelTitle(number int, title string) string {
-	return fmt.Sprintf("%d %s", number, title)
+func (gui *Gui) panelTitle(viewName string, number int, title string) string {
+	currentView := gui.g.CurrentView()
+	focused := currentView != nil && currentView.Name() == viewName
+	if currentView == nil {
+		focused = viewName == "packages"
+	}
+	return formatPanelTitle(number, title, focused)
+}
+
+func formatPanelTitle(number int, title string, focused bool) string {
+	marker := " "
+	if focused {
+		marker = ">"
+	}
+	return fmt.Sprintf("%s %d %s", marker, number, title)
 }
 
 func (gui *Gui) renderOptionsMap(optionsMap map[string]string) error {