Skip to content

Commit cf60648

Browse files
authored
Fix failing tests in CI (#826)
* Pin azure_datalake_store to version 0.0.53 see #825 * Remove failing assertion for traceback color codes * Pin ipython to version 8.37.0 see https://ipython.readthedocs.io/en/stable/whatsnew/version7.html#pending-deprecated-imports * Resolve Path before comparing
1 parent 5384731 commit cf60648

4 files changed

Lines changed: 7 additions & 5 deletions

File tree

papermill/tests/test_execute.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,6 @@ def test_output_formatting(self):
447447
# exception should be thrown by now
448448
self.assertFalse(True)
449449
except PapermillExecutionError as ex:
450-
self.assertEqual(ex.traceback[1], "\x1b[0;31mSystemExit\x1b[0m\x1b[0;31m:\x1b[0m 1\n")
451450
self.assertEqual(strip_color(ex.traceback[1]), "SystemExit: 1\n")
452451

453452
nb = load_notebook_node(result_path)

papermill/tests/test_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def test_chdir():
5454
old_cwd = Path.cwd()
5555
with TemporaryDirectory() as temp_dir:
5656
with chdir(temp_dir):
57-
assert Path.cwd() != old_cwd
58-
assert Path.cwd() == Path(temp_dir)
57+
assert Path.cwd().resolve() != old_cwd.resolve()
58+
assert Path.cwd().resolve() == Path(temp_dir).resolve()
5959

6060
assert Path.cwd() == old_cwd

requirements/azure.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
azure-datalake-store >= 0.0.30
1+
# newer versions require changes to authentication
2+
# see https://github.com/nteract/papermill/issues/825
3+
azure-datalake-store >= 0.0.30,<1.0.0a0
24
azure-storage-blob >= 12.1.0
35
requests >= 2.21.0
46
azure-identity>=1.3.1

requirements/dev.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ botocore
33
codecov
44
coverage
55
google_compute_engine # Need this because boto has issues with dynamic package loading during tests if other google components are there
6-
ipython>=5.0
6+
# newer versions of ipython have different imports and require refactoring
7+
ipython>=5.0,<9.0.0
78
ipywidgets
89
notebook
910
moto >= 5.0.0,<5.1.0

0 commit comments

Comments
 (0)