Review fixes

Author: emeeks

docs/src/pages/charts/ChordDiagramPage.js

@@ -289,7 +289,7 @@ export default function ChordDiagramPage() {
 ]`,
           colorBy: '"id"',
           edgeColorBy: '"source"',
-          colorScheme: '["#6366f1", "#22c55e", "##f59e0b", "#ef4444", "#06b6d4"]',
+          colorScheme: '["#6366f1", "#22c55e", "#f59e0b", "#ef4444", "#06b6d4"]',
           edgeOpacity: "0.4",
           padAngle: "0.03",
         }}

src/components/charts/shared/statisticalOverlays.ts

@@ -192,27 +192,12 @@ function buildPrecomputed(
     return { ...d, [SEGMENT_FIELD]: segment }
   })
 
-  // Collect training-base copies BEFORE boundary duplication so they don't
-  // interfere with the sequential boundary-point logic.
-  const trainBaseCopies: Record<string, any>[] = []
-  if (config.trainUnderline) {
-    for (const d of tagged) {
-      if (d[SEGMENT_FIELD] === "training") {
-        trainBaseCopies.push({ ...d, [SEGMENT_FIELD]: "training-base" as SegmentType })
-      }
-    }
-  }
-
   // Duplicate boundary points so adjacent segments share an endpoint (no gap).
   // When _groupBy is set (multi-metric data), we must group by metric first
   // because the flat data is interleaved by timestamp (A_t1, B_t1, A_t2, B_t2...),
   // so adjacent-pair scanning would never find within-group segment transitions.
   const groupByField = config._groupBy
   const processedData: Record<string, any>[] = []
-  // Prepend training-base copies so they appear first in the data stream —
-  // PipelineStore iterates groups in insertion order, so the solid underline
-  // renders before (beneath) the dashed training line.
-  processedData.push(...trainBaseCopies)
 
   if (groupByField) {
     // Group-aware boundary duplication: collect points per group, find
@@ -254,6 +239,20 @@ function buildPrecomputed(
     }
   }
 
+  // Collect training-base copies AFTER boundary duplication so the solid
+  // underline includes bridge points and covers the same x-extent as the
+  // dashed training segment.
+  if (config.trainUnderline) {
+    const trainBaseCopies: Record<string, any>[] = []
+    for (const d of processedData) {
+      if (d[SEGMENT_FIELD] === "training") {
+        trainBaseCopies.push({ ...d, [SEGMENT_FIELD]: "training-base" as SegmentType })
+      }
+    }
+    // Prepend so training-base renders first (beneath the dashed training line)
+    processedData.unshift(...trainBaseCopies)
+  }
+
   const annotations: Record<string, any>[] = []
 
   // Envelope from upper/lower bounds

src/components/charts/xy/LineChart.tsx

@@ -375,8 +375,8 @@ export const LineChart = forwardRef(
   // When the user provides a function accessor, we bake resolved values into
   // each datum under a synthetic field so the overlay pipeline + annotation
   // renderer can access them by string key.
-  const xAccStr = typeof xAccessor === "string" ? xAccessor : "__resolvedX"
-  const yAccStr = typeof yAccessor === "string" ? yAccessor : "__resolvedY"
+  const xAccStr = typeof xAccessor === "string" ? xAccessor : "__semiotic_resolvedX"
+  const yAccStr = typeof yAccessor === "string" ? yAccessor : "__semiotic_resolvedY"
 
   // Lazy-load statistical overlays — only fetches the module when forecast/anomaly props are used
   const [statisticalResult, setStatisticalResult] = useState<{
@@ -393,8 +393,8 @@ export const LineChart = forwardRef(
     if (!needsX && !needsY) return safeData as Record<string, any>[]
     return (safeData as Record<string, any>[]).map(d => {
       const copy = { ...d }
-      if (needsX) copy.__resolvedX = (xAccessor as (d: any) => any)(d)
-      if (needsY) copy.__resolvedY = (yAccessor as (d: any) => any)(d)
+      if (needsX) copy.__semiotic_resolvedX = (xAccessor as (d: any) => any)(d)
+      if (needsY) copy.__semiotic_resolvedY = (yAccessor as (d: any) => any)(d)
       return copy
     })
   }, [safeData, forecast, anomaly, xAccessor, yAccessor])