fixes

Author: emeeks

ai/system-prompt.md

@@ -58,7 +58,7 @@ const chartRef = useRef()
 chartRef.current.push({ x: 1, y: 2 })
 <Scatterplot ref={chartRef} xAccessor="x" yAccessor="y" />
 ```
-Methods: `push(datum)`, `pushMany(data)`, `remove(id)` (requires `pointIdAccessor`/`dataIdAccessor`), `update(id, updater)`, `clear()`, `getData()`. Network charts: `removeNode(id)`, `removeEdge(sourceId, targetId)`, `updateNode(id, updater)`, `updateEdge(sourceId, targetId, updater)`. Streaming-specific props (`windowSize`, `decay`, `pulse`) go in `frameProps`. Supported: XY charts, ordinal charts, network charts (ForceDirectedGraph, SankeyDiagram, ChordDiagram), ProportionalSymbolMap, DistanceCartogram. Not supported: hierarchy charts (TreeDiagram, Treemap, CirclePack, OrbitDiagram), ChoroplethMap, FlowMap, ScatterplotMatrix.
+Methods: `push(datum)`, `pushMany(data)`, `remove(id)` (requires `pointIdAccessor`/`dataIdAccessor`), `update(id, updater)`, `clear()`, `getData()`. Network charts: `removeNode(id)`, `removeEdge(sourceId, targetId)`, `updateNode(id, updater)`, `updateEdge(sourceId, targetId, updater)`. Geo charts: `update()` is implemented as remove+push internally. Streaming-specific props (`windowSize`, `decay`, `pulse`) go in `frameProps`. Supported: XY charts, ordinal charts, network charts (ForceDirectedGraph, SankeyDiagram, ChordDiagram), ProportionalSymbolMap, DistanceCartogram. Not supported: hierarchy charts (TreeDiagram, Treemap, CirclePack, OrbitDiagram), ChoroplethMap, FlowMap, ScatterplotMatrix.
 
 For advanced streaming control, use Stream Frames (`StreamXYFrame`, `StreamOrdinalFrame`, `StreamNetworkFrame`) with `runtimeMode="streaming"` and ref-based push.
 

docs/src/pages/features/PushApiPage.js

@@ -191,12 +191,6 @@ function NetworkDemo() {
     setLog(prev => ['removeNode("Cache") — edges cascade', ...prev].slice(0, 10))
   }, [])
 
-  const removeEdge = useCallback(() => {
-    // This removes via the HOC's remove() which maps to removeNode
-    // For edge removal, users go through frameProps or the stream frame directly
-    setLog(prev => ["Edge removal: use StreamNetworkFrame ref.removeEdge(src, tgt)", ...prev].slice(0, 10))
-  }, [])
-
   const addEdge = useCallback(() => {
     ref.current?.push({ source: "Web", target: "DB" })
     setLog(prev => ['push({ source: "Web", target: "DB" })', ...prev].slice(0, 10))
@@ -277,7 +271,8 @@ ref.current.getData()                                  // read current data`} la
       <p>
         <code>remove()</code> and <code>update()</code> require an ID accessor so
         the store can find the item to modify. XY charts use <code>pointIdAccessor</code>,
-        ordinal charts use <code>dataIdAccessor</code>.
+        ordinal charts use <code>dataIdAccessor</code>. Geo charts implement
+        <code>update()</code> as remove + push internally.
       </p>
 
       <h2>Push + Remove: Scatterplot</h2>

src/components/charts/geo/DistanceCartogram.tsx

@@ -235,7 +235,11 @@ export const DistanceCartogram = forwardRef(function DistanceCartogram<TDatum ex
     push: (point) => geoRef.current?.push(point),
     pushMany: (points) => geoRef.current?.pushMany(points),
     remove: (id) => geoRef.current?.removePoint(id) ?? [],
-    update: () => { throw new Error("update() not supported on geo charts — use removePoint + push") },
+    update: (id, updater) => {
+      const removed = geoRef.current?.removePoint(id) ?? []
+      for (const old of removed) geoRef.current?.push(updater(old))
+      return removed
+    },
     clear: () => geoRef.current?.clear(),
     getData: () => geoRef.current?.getData() ?? []
   }))

src/components/charts/geo/ProportionalSymbolMap.tsx

@@ -77,7 +77,11 @@ export const ProportionalSymbolMap = forwardRef(function ProportionalSymbolMap<T
     push: (point) => frameRef.current?.push(point),
     pushMany: (points) => frameRef.current?.pushMany(points),
     remove: (id) => frameRef.current?.removePoint(id) ?? [],
-    update: () => { throw new Error("update() not supported on geo charts — use removePoint + push") },
+    update: (id, updater) => {
+      const removed = frameRef.current?.removePoint(id) ?? []
+      for (const old of removed) frameRef.current?.push(updater(old))
+      return removed
+    },
     clear: () => frameRef.current?.clear(),
     getData: () => frameRef.current?.getData() ?? []
   }))
@@ -245,6 +249,7 @@ export const ProportionalSymbolMap = forwardRef(function ProportionalSymbolMap<T
     xAccessor: xAccessor as any,
     yAccessor: yAccessor as any,
     pointStyle: pointStyleFn,
+    ...(props.pointIdAccessor && { pointIdAccessor: props.pointIdAccessor }),
     ...(resolvedAreas && { areas: resolvedAreas, areaStyle }),
     ...(graticule != null && { graticule }),
     ...(fitPadding != null && { fitPadding }),

src/components/stream/NetworkPipelineStore.ts

@@ -993,7 +993,12 @@ export class NetworkPipelineStore {
       if (src === sourceId && tgt === targetId) {
         const previous = edge.data ?? {}
         edge.data = updater(previous)
-        const newValue = edge.data?.value
+        // Re-derive edge.value using the configured valueAccessor
+        const valAcc = this.config.valueAccessor
+        const valFn = typeof valAcc === "function" ? valAcc
+          : valAcc ? (d: any) => d[valAcc]
+          : (d: any) => d.value
+        const newValue = valFn(edge.data)
         if (newValue != null) edge.value = Number(newValue)
         this.layoutVersion++
         return previous

src/components/stream/PipelineStore.ts

@@ -1035,10 +1035,16 @@ export class PipelineStore {
     const removed = this.buffer.remove(item => ids.has(getPointId(item)))
     if (removed.length === 0) return removed
 
-    // Evict removed values from extent tracking
+    // Evict removed values from extent tracking — mirror ingest() logic
     for (const d of removed) {
       this.xExtent.evict(this.getX(d))
-      this.yExtent.evict(this.getY(d))
+      if (this.config.chartType === "candlestick" && this.getHigh && this.getLow) {
+        this.yExtent.evict(this.getHigh(d))
+        this.yExtent.evict(this.getLow(d))
+      } else {
+        this.yExtent.evict(this.getY(d))
+        if (this.getY0) this.yExtent.evict(this.getY0(d))
+      }
     }
 
     this.needsFullRebuild = true
@@ -1064,16 +1070,28 @@ export class PipelineStore {
     )
     if (previous.length === 0) return previous
 
-    // Evict old values, push new values into extent tracking
+    // Evict old values — mirror ingest() logic for candlestick/y0
     for (const old of previous) {
       this.xExtent.evict(this.getX(old))
-      this.yExtent.evict(this.getY(old))
+      if (this.config.chartType === "candlestick" && this.getHigh && this.getLow) {
+        this.yExtent.evict(this.getHigh(old))
+        this.yExtent.evict(this.getLow(old))
+      } else {
+        this.yExtent.evict(this.getY(old))
+        if (this.getY0) this.yExtent.evict(this.getY0(old))
+      }
     }
     // Push new extents from the updated buffer
     this.buffer.forEach(d => {
       if (ids.has(getPointId(d))) {
         this.xExtent.push(this.getX(d))
-        this.yExtent.push(this.getY(d))
+        if (this.config.chartType === "candlestick" && this.getHigh && this.getLow) {
+          this.yExtent.push(this.getHigh(d))
+          this.yExtent.push(this.getLow(d))
+        } else {
+          this.yExtent.push(this.getY(d))
+          if (this.getY0) this.yExtent.push(this.getY0(d))
+        }
       }
     })
 

src/components/stream/remove.test.tsx

@@ -1,8 +1,6 @@
 import { TextEncoder, TextDecoder } from "util"
 Object.assign(global, { TextEncoder, TextDecoder })
 
-import React from "react"
-import { render } from "@testing-library/react"
 import { PipelineStore } from "./PipelineStore"
 import { OrdinalPipelineStore } from "./OrdinalPipelineStore"
 import { NetworkPipelineStore } from "./NetworkPipelineStore"