SharedCfg is not Copy (#766)

Author: fafhrd91

.github/workflows/miri.yml

@@ -28,6 +28,14 @@ jobs:
       - name: Cache Dependencies
         uses: Swatinem/rust-cache@v2.8.2
 
-      - name: Run Miri
+      - name: Run Miri (bytes)
         # Run all of your tests inside of Miri interpreter
         run: cargo miri test -p ntex-bytes
+
+      - name: Run Miri (ntex-service::cfg)
+        # Run all of your tests inside of Miri interpreter
+        run: cargo miri test -p ntex-service -- --test "cfg::tests::"
+
+      - name: Run Miri (ntex-io)
+        # Run all of your tests inside of Miri interpreter
+        run: cargo miri test -p ntex-io -- --test "miri_"

Cargo.toml

@@ -26,7 +26,7 @@ edition = "2024"
 rust-version = "1.88"
 
 [workspace.lints.rust]
-async_fn_in_trait =  { level = "allow", priority = -1 }
+async_fn_in_trait = { level = "allow", priority = -1 }
 rust_2018_idioms = "deny"
 warnings = "deny"
 unreachable_pub = "deny"
@@ -54,18 +54,18 @@ ntex-util = { path = "ntex-util" }
 ntex = "3.3.0"
 ntex-bytes = "1.5.0"
 ntex-codec = "1.1.0"
-ntex-io = "3.7.1"
+ntex-io = "3.9.0"
 ntex-dispatcher = "3.1.0"
-ntex-net = "3.6.3"
+ntex-net = "3.7.0"
 ntex-http = "1.0.0"
 ntex-router = "1.0.0"
 ntex-rt = "3.7.0"
-ntex-server = "3.7.0"
-ntex-service = "4.4.0"
-ntex-tls = "3.2.1"
+ntex-server = "3.8.0"
+ntex-service = "4.5.0"
+ntex-tls = "3.3.0"
 ntex-macros = "3.1.0"
 ntex-util = "3.4.0"
-ntex-h2 = "3.6.2"
+ntex-h2 = "3.7.1"
 
 ntex-polling = "3.10.0"
 ntex-io-uring = "0.7.120"

ntex-io/CHANGES.md

@@ -1,5 +1,9 @@
 # Changes
 
+## [3.9.0] - 2026-02-16
+
+* SharedCfg is not Copy
+
 ## [3.8.0] - 2026-02-03
 
 * Refactor Io filter management

ntex-io/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex-io"
-version = "3.8.0"
+version = "3.9.0"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "Utilities for abstracting io streams"
 keywords = ["network", "framework", "async", "futures"]

ntex-io/src/cfg.rs

@@ -13,7 +13,7 @@ thread_local! {
     static CACHE: LocalCache = LocalCache::new();
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 /// Base io configuration
 pub struct IoConfig {
     connect_timeout: Millis,
@@ -43,9 +43,9 @@ impl Configuration for IoConfig {
     }
 
     fn set_ctx(&mut self, ctx: CfgContext) {
-        self.config = ctx;
         self.read_buf.idx = ctx.id();
         self.write_buf.idx = ctx.id();
+        self.config = ctx;
     }
 }
 
@@ -72,6 +72,7 @@ impl IoConfig {
     /// Create new config object
     pub fn new() -> IoConfig {
         let config = CfgContext::default();
+        let idx = config.id();
 
         IoConfig {
             config,
@@ -81,18 +82,18 @@ impl IoConfig {
             frame_read_rate: None,
 
             read_buf: BufConfig {
+                idx,
                 high: DEFAULT_HIGH,
                 low: DEFAULT_LOW,
                 half: DEFAULT_HALF,
-                idx: config.id(),
                 first: true,
                 cache_size: DEFAULT_CACHE_SIZE,
             },
             write_buf: BufConfig {
+                idx,
                 high: DEFAULT_HIGH,
                 low: DEFAULT_LOW,
                 half: DEFAULT_HALF,
-                idx: config.id(),
                 first: false,
                 cache_size: DEFAULT_CACHE_SIZE,
             },

ntex-io/src/filterptr.rs

@@ -209,7 +209,7 @@ mod tests {
     }
 
     #[test]
-    fn take_sealed_filter() {
+    fn miri_sealed_filter() {
         let p = Rc::new(Cell::new(0));
         let f = DropFilter { p: p.clone() };
 
@@ -219,7 +219,7 @@ mod tests {
 
     #[test]
     #[should_panic(expected = "Filter is not set")]
-    fn take_filter_access() {
+    fn miri_filter_access() {
         let fptr = FilterPtr::null();
         fptr.filter::<Base>();
     }

ntex-io/src/io.rs

@@ -4,7 +4,7 @@ use std::task::{Context, Poll};
 use std::{fmt, hash, io, marker, mem, ops, pin::Pin, ptr, rc::Rc};
 
 use ntex_codec::{Decoder, Encoder};
-use ntex_service::cfg::SharedCfg;
+use ntex_service::cfg::{Cfg, SharedCfg};
 use ntex_util::{future::Either, task::LocalWaker};
 
 use crate::buf::Stack;
@@ -24,7 +24,7 @@ pub struct IoRef(pub(super) Rc<IoState>);
 
 pub(crate) struct IoState {
     filter: FilterPtr,
-    pub(super) cfg: Cell<&'static IoConfig>,
+    pub(super) cfg: Cfg<IoConfig>,
     pub(super) flags: Cell<Flags>,
     pub(super) error: Cell<Option<io::Error>>,
     pub(super) read_task: LocalWaker,
@@ -65,7 +65,7 @@ impl IoState {
             flags.insert(Flags::DSP_TIMEOUT);
             self.flags.set(flags);
             self.dispatch_task.wake();
-            log::trace!("{}: Timer, notify dispatcher", self.cfg.get().tag());
+            log::trace!("{}: Timer, notify dispatcher", self.cfg.tag());
         }
     }
 
@@ -98,7 +98,7 @@ impl IoState {
         if !self.flags.get().is_stopped() {
             log::trace!(
                 "{}: {:?} Io error {:?} flags: {:?}",
-                self.cfg.get().tag(),
+                self.cfg.tag(),
                 ptr::from_ref(self),
                 err,
                 self.flags.get()
@@ -120,7 +120,7 @@ impl IoState {
             if !self.dispatch_task.wake_checked() {
                 log::trace!(
                     "{}: {:?} Dispatcher is not registered, flags: {:?}",
-                    self.cfg.get().tag(),
+                    self.cfg.tag(),
                     ptr::from_ref(self),
                     self.flags.get()
                 );
@@ -137,7 +137,7 @@ impl IoState {
         {
             log::trace!(
                 "{}: Initiate io shutdown {:?}",
-                self.cfg.get().tag(),
+                self.cfg.tag(),
                 self.flags.get()
             );
             self.insert_flags(Flags::IO_STOPPING_FILTERS);
@@ -147,12 +147,12 @@ impl IoState {
 
     #[inline]
     pub(super) fn read_buf(&self) -> &BufConfig {
-        self.cfg.get().read_buf()
+        self.cfg.read_buf()
     }
 
     #[inline]
     pub(super) fn write_buf(&self) -> &BufConfig {
-        self.cfg.get().write_buf()
+        self.cfg.write_buf()
     }
 }
 
@@ -194,7 +194,7 @@ impl Io {
     /// Create `Io` instance
     pub fn new<I: IoStream, T: Into<SharedCfg>>(io: I, cfg: T) -> Self {
         let inner = Rc::new(IoState {
-            cfg: Cell::new(cfg.into().get::<IoConfig>().into_static()),
+            cfg: cfg.into().get::<IoConfig>(),
             filter: FilterPtr::null(),
             flags: Cell::new(Flags::WR_PAUSED),
             error: Cell::new(None),
@@ -237,7 +237,7 @@ impl<F> Io<F> {
 
     fn take_io_ref(&self) -> IoRef {
         let inner = Rc::new(IoState {
-            cfg: Cell::new(SharedCfg::default().get::<IoConfig>().into_static()),
+            cfg: SharedCfg::default().get::<IoConfig>(),
             filter: FilterPtr::null(),
             flags: Cell::new(
                 Flags::IO_STOPPED | Flags::IO_STOPPING | Flags::IO_STOPPING_FILTERS,
@@ -278,9 +278,9 @@ impl<F> Io<F> {
     #[inline]
     /// Set shared io config
     pub fn set_config<T: Into<SharedCfg>>(&self, cfg: T) {
-        self.st()
-            .cfg
-            .set(cfg.into().get::<IoConfig>().into_static());
+        unsafe {
+            self.st().cfg.replace(cfg.into().get::<IoConfig>());
+        }
     }
 }
 
@@ -708,7 +708,7 @@ impl<F> Drop for Io<F> {
             if !st.flags.get().is_stopped() {
                 log::trace!(
                     "{}: Io is dropped, force stopping io streams {:?}",
-                    st.cfg.get().tag(),
+                    st.cfg.tag(),
                     st.flags.get()
                 );
             }

ntex-io/src/ioref.rs

@@ -14,7 +14,7 @@ impl IoRef {
     #[inline]
     /// Get tag
     pub fn tag(&self) -> &'static str {
-        self.0.cfg.get().tag()
+        self.0.cfg.tag()
     }
 
     #[inline]
@@ -32,14 +32,14 @@ impl IoRef {
 
     #[inline]
     /// Get configuration
-    pub fn cfg(&self) -> &'static IoConfig {
-        self.0.cfg.get()
+    pub fn cfg(&self) -> &IoConfig {
+        &self.0.cfg
     }
 
     #[inline]
     /// Get shared configuration
     pub fn shared(&self) -> SharedCfg {
-        self.0.cfg.get().config.shared()
+        self.0.cfg.shared()
     }
 
     #[inline]

ntex-net/CHANGES.md

@@ -1,5 +1,9 @@
 # Changes
 
+## [3.7.0] - 2026-02-16
+
+* SharedCfg is not Copy
+
 ## [3.6.3] - 2026-02-12
 
 * Fix compio io shutdown

ntex-net/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex-net"
-version = "3.6.3"
+version = "3.7.0"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "ntexwork utils for ntex framework"
 keywords = ["network", "framework", "async", "futures"]