Unify JoinHandle for all runtimes (#744)

Author: fafhrd91

.github/workflows/linux.yml

@@ -33,43 +33,41 @@ jobs:
         uses: Swatinem/rust-cache@v2.8.2
 
       - name: Run tests (neon-polling)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: |
           cargo nextest run --retries=3 --all --no-default-features --features="ntex/neon-polling,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run doc tests (neon-polling)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: |
           cargo test --doc --all --no-default-features --features="ntex/neon-polling,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run tests (neon-uring)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: |
           cargo nextest run --retries=3 --all --no-default-features --features="ntex/neon-uring,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run doc tests (neon-uring)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: |
           cargo test --doc --all --no-default-features --features="ntex/neon-uring,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run tests (tokio)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: |
           cargo nextest run --retries=3 --all --no-default-features --features="ntex/tokio,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run doc tests (tokio)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: |
           cargo test --doc --all --no-default-features --features="ntex/tokio,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run tests (compio)
-        timeout-minutes: 15
-        if: matrix.version != '1.86.0'
+        timeout-minutes: 10
         run: |
           cargo nextest run --retries=3 --all --no-default-features --features="ntex/compio,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run doc tests (compio)
-        timeout-minutes: 15
-        if: matrix.version != '1.86.0'
+        timeout-minutes: 10
         run: |
           cargo test --doc --all --no-default-features --features="ntex/compio,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"

.github/workflows/osx.yml

@@ -32,13 +32,13 @@ jobs:
         uses: Swatinem/rust-cache@v2.8.2
 
       - name: Run tests (neon)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: cargo nextest run --retries=3 --all --no-default-features --no-fail-fast --features="ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run tests (tokio)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: cargo nextest run --retries=3 --all --no-default-features --no-fail-fast --features="ntex/tokio,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"
 
       - name: Run tests (compio)
-        timeout-minutes: 15
+        timeout-minutes: 10
         run: cargo nextest run --retries=3 --all --no-default-features --features="ntex/compio,ntex/cookie,ntex/url,ntex/compress,ntex/openssl,ntex/rustls,ntex/ws"

Cargo.toml

@@ -59,7 +59,7 @@ ntex-dispatcher = "3.0.0"
 ntex-net = "3.6.1"
 ntex-http = "1.0.0"
 ntex-router = "1.0.0"
-ntex-rt = "3.6.0"
+ntex-rt = "3.7.0"
 ntex-server = "3.6.0"
 ntex-service = "4.0.0"
 ntex-tls = "3.2.0"

ntex-bytes/tests/test_bytes.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::op_ref, clippy::let_underscore_future)]
+#![allow(clippy::op_ref)]
 use std::{borrow::Borrow, borrow::BorrowMut};
 
 use ntex_bytes::info::Kind;

ntex-io/src/filterptr.rs

@@ -32,10 +32,7 @@ impl FilterPtr {
 
     pub(crate) fn set<F: Filter>(&self, filter: F) {
         let filter = Box::new(filter);
-        let filter_ref = {
-            let f: &dyn Filter = filter.as_ref();
-            f as *const dyn Filter
-        };
+        let filter_ref = ptr::from_ref::<dyn Filter>(filter.as_ref());
         *self.as_mut() = Repr::Filter(Box::into_raw(filter).cast(), filter_ref);
     }
 
@@ -91,10 +88,7 @@ impl FilterPtr {
         let repr = match self.as_ref() {
             Repr::Filter(..) => {
                 let filter = Box::new(Layer::new(new, *self.take_filter::<F>()));
-                let filter_ref = {
-                    let f: &dyn Filter = filter.as_ref();
-                    f as *const dyn Filter
-                };
+                let filter_ref = ptr::from_ref::<dyn Filter>(filter.as_ref());
                 Repr::Filter(Box::into_raw(filter).cast(), filter_ref)
             }
             Repr::Sealed(..) => Repr::Sealed(Box::new(Layer::new(new, self.take_sealed()))),
@@ -108,10 +102,7 @@ impl FilterPtr {
         R: Filter,
     {
         let filter = Box::new(f(*self.take_filter::<F>()));
-        let filter_ref = {
-            let f: &dyn Filter = filter.as_ref();
-            f as *const dyn Filter
-        };
+        let filter_ref = ptr::from_ref::<dyn Filter>(filter.as_ref());
         *self.as_mut() = Repr::Filter(Box::into_raw(filter).cast(), filter_ref);
     }
 

ntex-io/src/timer.rs

@@ -129,8 +129,7 @@ pub(crate) fn register(timeout: Seconds, io: &IoRef) -> TimerHandle {
         if !timer.running.get() {
             timer.running.set(true);
 
-            #[allow(clippy::let_underscore_future)]
-            let _ = spawn(async move {
+            spawn(async move {
                 let guard = TimerGuard;
                 loop {
                     sleep(SEC).await;

ntex-rt/CHANGES.md

@@ -1,5 +1,13 @@
 # Changes
 
+## [3.7.0] - 2026-02-04
+
+* Unify JoinHandle for all runtimes
+
+## [3.6.0] - 2026-02-02
+
+* Update compio to 0.18
+
 ## [3.5.0] - 2026-02-01
 
 * Update compio to 0.18

ntex-rt/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex-rt"
-version = "3.6.0"
+version = "3.7.0"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "ntex runtime"
 keywords = ["network", "framework", "async", "futures"]

ntex-rt/src/arbiter.rs

@@ -122,7 +122,7 @@ impl Arbiter {
 
                 config.block_on(async move {
                     // start arbiter controller
-                    let _ = crate::spawn(
+                    crate::spawn(
                         ArbiterController {
                             stop: Some(stop),
                             rx: arb_rx,
@@ -343,7 +343,7 @@ impl ArbiterController {
                     break;
                 }
                 Ok(ArbiterCommand::Execute(fut)) => {
-                    let _ = crate::spawn(fut);
+                    crate::spawn(fut);
                 }
                 Ok(ArbiterCommand::ExecuteFn(f)) => {
                     f.call_box();

ntex-rt/src/builder.rs

@@ -194,8 +194,8 @@ impl SystemRunner {
         config.block_on(async move {
             f()?;
 
-            let _ = crate::spawn(support.run());
-            let _ = crate::spawn(controller.run());
+            crate::spawn(support.run());
+            crate::spawn(controller.run());
             match stop.await {
                 Ok(code) => {
                     if code != 0 {
@@ -223,8 +223,8 @@ impl SystemRunner {
         } = self;
 
         config.block_on(async move {
-            let _ = crate::spawn(support.run());
-            let _ = crate::spawn(controller.run());
+            crate::spawn(support.run());
+            crate::spawn(controller.run());
             fut.await
         })
     }
@@ -245,8 +245,8 @@ impl SystemRunner {
         // run loop
         tok_io::task::LocalSet::new()
             .run_until(async move {
-                let _ = crate::spawn(support.run());
-                let _ = crate::spawn(controller.run());
+                crate::spawn(support.run());
+                crate::spawn(controller.run());
                 fut.await
             })
             .await