Skip to content

Commit d6ae114

Browse files
committed
update tests
1 parent c0376b9 commit d6ae114

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

ntex/src/web/middleware/logger.rs

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use std::rc::Rc;
1010
use std::task::{Context, Poll};
1111

1212
use bytes::Bytes;
13-
use futures::future::{ok, Ready};
13+
use futures::future::{ok, Either, Ready};
1414
use regex::Regex;
1515
use time::OffsetDateTime;
1616

@@ -154,7 +154,7 @@ where
154154
type Request = WebRequest<E>;
155155
type Response = WebResponse;
156156
type Error = S::Error;
157-
type Future = LoggerResponse<S>;
157+
type Future = Either<LoggerResponse<S>, S::Future>;
158158

159159
#[inline]
160160
fn poll_ready(&self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
@@ -169,23 +169,19 @@ where
169169
#[inline]
170170
fn call(&self, req: WebRequest<E>) -> Self::Future {
171171
if self.inner.exclude.contains(req.path()) {
172-
LoggerResponse {
173-
fut: self.service.call(req),
174-
format: None,
175-
time: OffsetDateTime::now(),
176-
}
172+
Either::Right(self.service.call(req))
177173
} else {
178-
let now = OffsetDateTime::now();
174+
let time = OffsetDateTime::now();
179175
let mut format = self.inner.format.clone();
180176

181177
for unit in &mut format.0 {
182-
unit.render_request(now, &req);
178+
unit.render_request(time, &req);
183179
}
184-
LoggerResponse {
185-
fut: self.service.call(req),
180+
Either::Left(LoggerResponse {
181+
time,
186182
format: Some(format),
187-
time: now,
188-
}
183+
fut: self.service.call(req),
184+
})
189185
}
190186
}
191187
}
@@ -514,6 +510,11 @@ mod tests {
514510
let res = srv.call(req).await.unwrap();
515511
let body = test::read_body(res).await;
516512
assert_eq!(body, Bytes::from_static(b"TEST"));
513+
514+
let req = TestRequest::with_uri("/test").to_srv_request();
515+
let res = srv.call(req).await.unwrap();
516+
let body = test::read_body(res).await;
517+
assert_eq!(body, Bytes::from_static(b"TEST"));
517518
}
518519

519520
#[ntex_rt::test]

ntex/tests/http_awc_ws.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ async fn test_simple() {
3737
.await?;
3838

3939
// start websocket service
40-
let framed = framed.into_framed(ws::Codec::new());
40+
let framed = framed.into_framed(ws::Codec::default());
4141
Dispatcher::new(framed, ws_service).await
4242
}
4343
})

0 commit comments

Comments
 (0)