Skip to content

Commit 7666029

Browse files
yhl25yhl25
authored
chore: log stack traces (#167)
Signed-off-by: Yashash H L <[email protected]>
1 parent b6dbc09 commit 7666029

File tree

6 files changed

+25
-16
lines changed

6 files changed

+25
-16
lines changed

‎src/main/java/io/numaproj/numaflow/batchmapper/Service.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public void onNext(MapOuterClass.MapRequest mapRequest) {
9696
datumStream.writeMessage(constructHandlerDatum(mapRequest));
9797
}
9898
} catch (Exception e) {
99-
log.error("Encountered an error in batch map onNext - {}", e.getMessage());
99+
log.error("Encountered an error in batch map onNext", e);
100100
shutdownSignal.completeExceptionally(e);
101101
responseObserver.onError(Status.INTERNAL
102102
.withDescription(e.getMessage())
@@ -108,7 +108,7 @@ public void onNext(MapOuterClass.MapRequest mapRequest) {
108108
// Called when an error occurs
109109
@Override
110110
public void onError(Throwable throwable) {
111-
log.error("Error Encountered in batchMap Stream - {}", throwable.getMessage());
111+
log.error("Error Encountered in batchMap Stream", throwable);
112112
shutdownSignal.completeExceptionally(throwable);
113113
responseObserver.onError(Status.INTERNAL
114114
.withDescription(throwable.getMessage())

‎src/main/java/io/numaproj/numaflow/mapper/MapSupervisorActor.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,10 @@ public static Props props(
7070

7171
@Override
7272
public void preRestart(Throwable reason, Optional<Object> message) {
73-
getContext().getSystem().log().warning("supervisor pre restart was executed due to: {}", reason.getMessage());
73+
getContext()
74+
.getSystem()
75+
.log()
76+
.warning("supervisor pre restart was executed due to: {}", reason.getMessage());
7477
shutdownSignal.completeExceptionally(reason);
7578
responseObserver.onError(Status.INTERNAL
7679
.withDescription(reason.getMessage())
@@ -98,7 +101,7 @@ public Receive createReceive() {
98101
}
99102

100103
private void handleFailure(Exception e) {
101-
log.error("Encountered error in mapFn - {}", e.getMessage());
104+
log.error("Encountered error in mapFn", e);
102105
if (userException == null) {
103106
userException = e;
104107
// only send the very first exception to the client

‎src/main/java/io/numaproj/numaflow/mapstreamer/Service.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void onNext(MapOuterClass.MapRequest request) {
5959
constructHandlerDatum(request),
6060
new OutputObserverImpl(responseObserver));
6161
} catch (Exception e) {
62-
log.error("Encountered error in mapFn onNext - {}", e.getMessage());
62+
log.error("Encountered error in mapFn onNext", e);
6363
shutdownSignal.completeExceptionally(e);
6464
responseObserver.onError(Status.INTERNAL
6565
.withDescription(e.getMessage())
@@ -80,7 +80,7 @@ public void onNext(MapOuterClass.MapRequest request) {
8080

8181
@Override
8282
public void onError(Throwable throwable) {
83-
log.error("Encountered error in mapStream Stream - {}", throwable.getMessage());
83+
log.error("Encountered error in mapStream Stream", throwable);
8484
shutdownSignal.completeExceptionally(throwable);
8585
responseObserver.onError(Status.INTERNAL
8686
.withDescription(throwable.getMessage())

‎src/main/java/io/numaproj/numaflow/sinker/Service.java

+5-3
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,17 @@ public void onNext(SinkOuterClass.SinkRequest request) {
9595
datumStream.writeMessage(constructHandlerDatum(request));
9696
}
9797
} catch (Exception e) {
98-
log.error("Encountered error in sinkFn onNext - {}", e.getMessage());
98+
log.error("Encountered error in sinkFn onNext", e);
9999
shutdownSignal.completeExceptionally(e);
100-
responseObserver.onError(Status.INTERNAL.withDescription(e.getMessage()).asException());
100+
responseObserver.onError(Status.INTERNAL
101+
.withDescription(e.getMessage())
102+
.asException());
101103
}
102104
}
103105

104106
@Override
105107
public void onError(Throwable throwable) {
106-
log.error("Encountered error in sinkFn - {}", throwable.getMessage());
108+
log.error("Encountered error in sinkFn", throwable);
107109
shutdownSignal.completeExceptionally(throwable);
108110
responseObserver.onError(Status.INTERNAL
109111
.withDescription(throwable.getMessage())

‎src/main/java/io/numaproj/numaflow/sourcer/Service.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,14 @@ public void onNext(SourceOuterClass.ReadRequest request) {
7171
.setCode(SourceOuterClass.ReadResponse.Status.Code.SUCCESS)
7272
.build();
7373

74-
SourceOuterClass.ReadResponse response = SourceOuterClass.ReadResponse.newBuilder()
74+
SourceOuterClass.ReadResponse response = SourceOuterClass.ReadResponse
75+
.newBuilder()
7576
.setStatus(status)
7677
.build();
7778

7879
responseObserver.onNext(response);
7980
} catch (Exception e) {
80-
log.error("Encountered error in readFn onNext - {}", e.getMessage());
81+
log.error("Encountered error in readFn onNext", e);
8182
shutdownSignal.completeExceptionally(e);
8283
responseObserver.onError(Status.INTERNAL
8384
.withDescription(e.getMessage())
@@ -88,7 +89,7 @@ public void onNext(SourceOuterClass.ReadRequest request) {
8889

8990
@Override
9091
public void onError(Throwable t) {
91-
log.error("Encountered error in readFn onNext - {}", t.getMessage());
92+
log.error("Encountered error in readFn onNext", t);
9293
shutdownSignal.completeExceptionally(t);
9394
responseObserver.onError(Status.INTERNAL
9495
.withDescription(t.getMessage())
@@ -152,7 +153,7 @@ public void onNext(SourceOuterClass.AckRequest request) {
152153

153154
responseObserver.onNext(response);
154155
} catch (Exception e) {
155-
log.error("Encountered error in ackFn onNext - {}", e.getMessage());
156+
log.error("Encountered error in ackFn onNext", e);
156157
shutdownSignal.completeExceptionally(e);
157158
responseObserver.onError(Status.INTERNAL
158159
.withDescription(e.getMessage())
@@ -163,7 +164,7 @@ public void onNext(SourceOuterClass.AckRequest request) {
163164

164165
@Override
165166
public void onError(Throwable t) {
166-
log.error("Encountered error in ackFn onNext - {}", t.getMessage());
167+
log.error("Encountered error in ackFn onNext", t);
167168
shutdownSignal.completeExceptionally(t);
168169
responseObserver.onError(Status.INTERNAL
169170
.withDescription(t.getMessage())

‎src/main/java/io/numaproj/numaflow/sourcetransformer/TransformSupervisorActor.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,10 @@ public static Props props(
9696
*/
9797
@Override
9898
public void preRestart(Throwable reason, Optional<Object> message) {
99-
getContext().getSystem().log().warning("supervisor pre restart was executed due to: {}", reason.getMessage());
99+
getContext()
100+
.getSystem()
101+
.log()
102+
.warning("supervisor pre restart was executed due to: {}", reason.getMessage());
100103
responseObserver.onError(Status.INTERNAL
101104
.withDescription(reason.getMessage())
102105
.withCause(reason)
@@ -136,7 +139,7 @@ public Receive createReceive() {
136139
* @param e The exception to be handled.
137140
*/
138141
private void handleFailure(Exception e) {
139-
log.error("Encountered error in sourceTransformFn - {}", e.getMessage());
142+
log.error("Encountered error in sourceTransformFn", e);
140143
if (userException == null) {
141144
userException = e;
142145
// only send the very first exception to the client

0 commit comments

Comments
 (0)