Skip to content

Commit

Permalink
Refactor package build workflow
Browse files Browse the repository at this point in the history
* Merge llvmdev_win_builder.yml + llvmdev_win-64_conda_builder.yml into one
  to avoid code duplication
* Add input parameter to be able to select between recipes to build
* Rename flow to llvmdev_conda_builder.yml as it contains nothing specific
  to windows and the code is just a generic conda package builder
* Add ${{ matrix.recipe }}-${{ runner.os }} to upload name to better
  differentiate artifacts
* Remove "x" from `bash -elx {0}` as that pollutes the Action log due to
  the implicit `source "$CONDA/etc/profile.d/conda.sh` calls in every
  step.
* Set `run-post: false` to avoid setup-miniconda cleaning up the Github
  Action VM as that is wiped after the run anyways
* Run the flow if it gets changed in PRs, to see a public verfication
  that the changes are actually working
  • Loading branch information
dbast committed Feb 5, 2025
1 parent 0924039 commit 21a4c90
Show file tree
Hide file tree
Showing 5 changed files with 177 additions and 147 deletions.
108 changes: 108 additions & 0 deletions .github/workflows/llvmdev_build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
name: llvmdev

on:
pull_request:
paths:
- .github/workflows/llvmdev_build.yml
label:
types: [created]
workflow_dispatch:
inputs:
platform:
description: Conda Platform
default: linux-64
required: true
type: choice
options:
- linux-64
- linux-aarch64
- osx-64
- osx-arm64
- win-64
recipe:
description: Recipe to build
default: llvmdev
required: true
type: choice
options:
- llvmdev
- llvmdev_manylinux

concurrency:
# Concurrency group that uses the workflow name and PR number if available
# or commit SHA as a fallback. If a new build is triggered under that
# concurrency group while a previous build is running it will be canceled.
# Repeated pushes to a PR will cancel all previous builds, while multiple
# merges to master will not cancel.
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
cancel-in-progress: true

jobs:

check:
runs-on: ubuntu-24.04
outputs:
matrix: ${{ steps.evaluate.outputs.matrix }}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.13'
- name: Evaluate
id: evaluate
env:
GITHUB_EVENT_NAME: ${{ github.event_name }}
GITHUB_LABEL_NAME: ${{ github.event.label.name }}
GITHUB_WORKFLOW_INPUT: ${{ toJson(github.event.inputs) }}
run: |
./buildscripts/github/llvmdev_evaluate.py
build:
needs: check
name: ${{ matrix.recipe }}-${{ matrix.platform }}
runs-on: ${{ matrix.runner }}
defaults:
run:
shell: bash -el {0}
strategy:
matrix: ${{fromJson(needs.check.outputs.matrix)}}
fail-fast: false

steps:
- name: Clone repository
uses: actions/checkout@v4

- name: Setup Miniconda
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
auto-activate-base: true
activate-environment: ''
run-post: false

- name: Install conda-build
run: |
conda install conda-build
- name: Build conda package
env:
CONDA_CHANNEL_DIR: conda_channel_dir
run: |
set -x
mkdir "${CONDA_CHANNEL_DIR}"
conda build "./conda-recipes/${{ matrix.recipe }}" "--output-folder=${CONDA_CHANNEL_DIR}"
ls -lah "${CONDA_CHANNEL_DIR}"
- name: Upload conda package
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.recipe }}-${{ runner.platform }}
path: conda_channel_dir
compression-level: 0
retention-days: 7
if-no-files-found: error

- name: Get Workflow Run ID
run: |
echo "Current workflow run ID: ${{ github.run_id }}"
echo "Use this ID when triggering llvmlite workflow"
49 changes: 0 additions & 49 deletions .github/workflows/llvmdev_linux-64_conda_builder.yml

This file was deleted.

49 changes: 0 additions & 49 deletions .github/workflows/llvmdev_win-64_conda_builder.yml

This file was deleted.

49 changes: 0 additions & 49 deletions .github/workflows/llvmdev_win_builder.yml

This file was deleted.

69 changes: 69 additions & 0 deletions buildscripts/github/llvmdev_evaluate.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
#!/usr/bin/env python

import json
import os

event = os.environ.get("GITHUB_EVENT_NAME")
label = os.environ.get("GITHUB_LABEL_NAME")
inputs = os.environ.get("GITHUB_WORKFLOW_INPUT")

runner_mapping = {
"linux-64": "ubuntu-24.04",
"linux-aarch64": "ubuntu-24.04-arm",
"osx-64": "macos-13",
"osx-arm64": "macos-14",
"win-64": "windows-2019",
}

default_include = [
{ "runner": runner_mapping["linux-64"],
"platform": "linux-64",
"recipe": "llvmdev"},
{
"runner": runner_mapping["linux-aarch64"],
"platform": "linux-aarch64",
"recipe": "llvmdev",
},
{
"runner": runner_mapping["osx-arm64"],
"platform": "osx-arm64",
"recipe": "llvmdev",
},
{
"runner": runner_mapping["osx-arm64"],
"platform": "osx-arm64",
"recipe": "llvmdev_manylinux",
},
{ "runner": runner_mapping["win-64"],
"platform": "win-64",
"recipe": "llvmdev"},
{
"runner": runner_mapping["win-64"],
"platform": "win-64",
"recipe": "llvmdev_manylinux",
},
]

print(
f"event: '{event}', label: '{label}', inputs: '{inputs}', changed_files: '{changed_files}'"
)

if event == "pull_request":
# full matrix build
include = default_include
elif event == "label":
# reduced matrix build
include = default_include[0:1]
elif event == "workflow_dispatch":
# TBD
include = {}
else:
include = {}
matrix = {"include": include}

print(f"matrix:\n {json.dumps(matrix, indent=4)}")

#with open(os.environ["GITHUB_OUTPUT"], "a") as fh:
# print(f"{matrix}={json.dumps(matrix)}", file=fh)

print(f"::set-output name=matrix::{json.dumps(matrix)}")

0 comments on commit 21a4c90

Please sign in to comment.