Prevent re-enabling of pass timings

numba · Mar 5, 2025 · 395a996 · 395a996
1 parent 86255fe
commit 395a996
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/llvmlite/binding/newpassmanagers.py b/llvmlite/binding/newpassmanagers.py
@@ -222,7 +222,7 @@ def __init__(self, tm, pto):
         super().__init__(ffi.lib.LLVMPY_CreatePassBuilder(tm, pto))
         self._pto = pto
         self._tm = tm
-        self._time_passes_handler = TimePassesHandler()
+        self._time_passes_handler = None
 
     def getModulePassManager(self):
         return ModulePassManager(
@@ -238,18 +238,32 @@ def getFunctionPassManager(self):
 
     def start_pass_timing(self):
         """Enable the pass timers.
+
+        Raises
+        ------
+        RuntimeError
+            If pass timing is already enabled.
         """
+        if self._time_passes_handler:
+            raise RuntimeError("Pass builder should only have one \
+                pass timer at a time")
+        self._time_passes_handler = TimePassesHandler()
         ffi.lib.LLVMPY_EnableTimePasses(self, self._time_passes_handler)
 
     def finish_pass_timing(self):
         """Returns the pass timings report and disables the LLVM internal
         timers. Pass timers are enabled by ``start_pass_timing()``. If the
         timers are not enabled, this function will return an empty string.
+
         Returns
         -------
         res : str
             LLVM generated timing report.
         """
+
+        if not self._time_passes_handler:
+            raise RuntimeError("Pass timing is not enabled")
+
         with ffi.OutputString() as buf:
             ffi.lib.LLVMPY_ReportAndDisableTimePasses(
                 self._time_passes_handler, buf)

diff --git a/llvmlite/tests/test_binding.py b/llvmlite/tests/test_binding.py
@@ -3091,10 +3091,31 @@ def test_empty_report(self):
         pb = self.pb()
         mpm = pb.getModulePassManager()
         mpm.run(mod, pb)
+        pb.start_pass_timing()
         report = pb.finish_pass_timing()
         pb.close()
         self.assertFalse(report)
 
+    def test_multiple_timers_error(self):
+        mod = self.module()
+        pb = self.pb()
+        pb.start_pass_timing()
+        mpm = pb.getModulePassManager()
+        mpm.run(mod, pb)
+        pb.finish_pass_timing()
+        with self.assertRaises(RuntimeError):
+            pb.start_pass_timing()
+        pb.close()
+
+    def test_empty_report_error(self):
+        mod = self.module()
+        pb = self.pb()
+        mpm = pb.getModulePassManager()
+        mpm.run(mod, pb)
+        with self.assertRaises(RuntimeError):
+            pb.finish_pass_timing()
+        pb.close()
+
 
 class TestNewModulePassManager(BaseTest, NewPassManagerMixin):
     def pm(self):