From 85ec2717ee2eaae6dace25bace9299e9b1116805 Mon Sep 17 00:00:00 2001
From: Solvik Blum <solvik@solvik.fr>
Date: Wed, 21 Aug 2024 16:39:59 +0200
Subject: [PATCH] remove useless condition and simplify the method to get
 group's members

---
 gitlab2rbac.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/gitlab2rbac.py b/gitlab2rbac.py
index 5399756..a66a1d5 100644
--- a/gitlab2rbac.py
+++ b/gitlab2rbac.py
@@ -154,9 +154,8 @@ def _get_users_query_paginated(
         raw = gql_client.execute(
             query, variable_values=variable_values, parse_result=True
         )
-        results = raw.get("group").get("groupMembers")
-        nodes = results.get("nodes")
-        page_info = results.get("pageInfo")
+        nodes = []
+        page_info = {"hasNextPage": True}
         while page_info.get("hasNextPage"):
             variable_values["after"] = page_info.get("endCursor")
             results = (
@@ -293,10 +292,7 @@ def get_groups(self):
             timespent = time() - _start
             logging.debug(f"Fetched groups in {timespent} seconds")
             for result in gitlab_groups:
-                if (
-                    result.parent_id is None
-                    and result.name not in self.groups_ignore_list
-                ):
+                if result.name not in self.groups_ignore_list:
                     logging.info("|found group={}".format(result.name))
                     groups.append(result)
         return groups