Skip to content

Commit 73d735c

Browse files
committed
chore(pulumi-2.22.3): final minor cleanup from code review
Minor bookkeeping items from the milestone-wide code review: - Add inline comment on s3-replication QoS policy documenting the par5-only scope choice (mirror on pa7 if dual-sided throttling is required). - Document schema.json.functions = 41 vs prov.DataSources = 40 rationale: the extra entry is pulumi:providers:flashblade/terraformConfig, a provider-level function injected by the bridge, not a data source. - Add CONVENTIONS.md exception for bridge tests: TestProviderInfo_* is the approved pattern for tests under pulumi/provider/ (not TestUnit_). Skipped items (with rationale): - M1 go directives: pulumi/sdk/v3 v3.231.0 requires go >= 1.25.8, so pulumi/provider/go.mod correctly uses 1.25.8 (not aspirational — it is the minimum enforced by the toolchain). pulumi/sdk/go/go.mod uses 1.22 (bridge generator default, preserved across regeneration by Makefile bak/restore). Root go.mod stays at 1.25.0 (TF provider, no Pulumi SDK dep). No alignment needed. - go.work: go work sync triggers deep dep updates across all example go.mod files — too invasive for a minor cleanup item. IDE-only benefit does not justify the churn.
1 parent 52b46c2 commit 73d735c

4 files changed

Lines changed: 10 additions & 0 deletions

File tree

CONVENTIONS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,8 @@ Reference: `internal/provider/server_resource.go` (v0→v1→v2).
128128

129129
`TestUnit_<Resource>_<Operation>[_<Variant>]` — e.g. `TestUnit_Target_Get_Found`, `TestUnit_TargetResource_Lifecycle`, `TestUnit_TargetDataSource_Basic`.
130130

131+
**Exception — bridge tests:** tests under `pulumi/provider/` use the `TestProviderInfo_*` pattern because they test the Pulumi bridge ProviderInfo configuration, not individual TF resource/data source logic. This naming is intentional and approved.
132+
131133
### Client tests
132134

133135
`httptest.NewServer()`, mock `/api/login` for `x-auth-token`, use `newTestClient(t, srv)`. One test per CRUD + edge cases.

pulumi/examples/s3-replication-go/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,8 @@ func main() {
655655

656656
// ------------------------------------------------------------------
657657
// Step 14: QoS policy (optional)
658+
// QoS policy is managed centrally on the par5 side for this example.
659+
// Mirror on pa7 if dual-sided throttling is required.
658660
// ------------------------------------------------------------------
659661
if qos != nil {
660662
_, err := flashblade.NewQosPolicy(ctx, "this", &flashblade.QosPolicyArgs{

pulumi/examples/s3-replication-py/__main__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,8 @@
520520

521521
# ---------------------------------------------------------------------------
522522
# Step 14: QoS policy (optional)
523+
# QoS policy is managed centrally on the par5 side for this example.
524+
# Mirror on pa7 if dual-sided throttling is required.
523525
# ---------------------------------------------------------------------------
524526
if qos:
525527
flashblade.QosPolicy("this",

pulumi/provider/resources_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ import (
1414

1515
// Expected counts. Matches TF provider registrations (54 resources, 40 data sources).
1616
// Update when TF provider resource set changes.
17+
//
18+
// Note: schema.json contains 41 entries under "functions" — the extra entry is
19+
// "pulumi:providers:flashblade/terraformConfig", a provider-level function
20+
// injected by the bridge, not a data source. prov.DataSources = 40 is correct.
1721
const (
1822
expectedResources = 54
1923
expectedDataSources = 40

0 commit comments

Comments
 (0)