Commit 73d735c
committed
chore(pulumi-2.22.3): final minor cleanup from code review
Minor bookkeeping items from the milestone-wide code review:
- Add inline comment on s3-replication QoS policy documenting the par5-only
scope choice (mirror on pa7 if dual-sided throttling is required).
- Document schema.json.functions = 41 vs prov.DataSources = 40 rationale:
the extra entry is pulumi:providers:flashblade/terraformConfig, a
provider-level function injected by the bridge, not a data source.
- Add CONVENTIONS.md exception for bridge tests: TestProviderInfo_* is
the approved pattern for tests under pulumi/provider/ (not TestUnit_).
Skipped items (with rationale):
- M1 go directives: pulumi/sdk/v3 v3.231.0 requires go >= 1.25.8, so
pulumi/provider/go.mod correctly uses 1.25.8 (not aspirational — it is
the minimum enforced by the toolchain). pulumi/sdk/go/go.mod uses 1.22
(bridge generator default, preserved across regeneration by Makefile
bak/restore). Root go.mod stays at 1.25.0 (TF provider, no Pulumi SDK
dep). No alignment needed.
- go.work: go work sync triggers deep dep updates across all example
go.mod files — too invasive for a minor cleanup item. IDE-only benefit
does not justify the churn.1 parent 52b46c2 commit 73d735c
4 files changed
Lines changed: 10 additions & 0 deletions
File tree
- pulumi
- examples
- s3-replication-go
- s3-replication-py
- provider
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| 131 | + | |
| 132 | + | |
131 | 133 | | |
132 | 134 | | |
133 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
655 | 655 | | |
656 | 656 | | |
657 | 657 | | |
| 658 | + | |
| 659 | + | |
658 | 660 | | |
659 | 661 | | |
660 | 662 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
520 | 520 | | |
521 | 521 | | |
522 | 522 | | |
| 523 | + | |
| 524 | + | |
523 | 525 | | |
524 | 526 | | |
525 | 527 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
| |||
0 commit comments