fix(lint): resolve all 10 golangci-lint v2 issues

- errcheck: add _ = to io.Copy and w.Write return values (5 fixes)
- staticcheck SA1012: nil context → context.TODO() in auth_test.go
- staticcheck QF1003: if/else chain → tagged switch in filesystems_test.go
- staticcheck SA4017: assert IsNull() return value instead of ignoring it
- unused: remove fsType() and stateFromPlan() dead code

Author: SoulKyu

internal/client/auth.go

@@ -37,7 +37,7 @@ func LoginWithAPIToken(ctx context.Context, httpClient *http.Client, endpoint, a
 		return "", fmt.Errorf("login: POST /api/login: %w", err)
 	}
 	defer resp.Body.Close()
-	io.Copy(io.Discard, resp.Body)
+	_, _ = io.Copy(io.Discard, resp.Body)
 
 	if resp.StatusCode != http.StatusOK {
 		return "", fmt.Errorf("login: unexpected status %d", resp.StatusCode)

internal/client/auth_test.go

@@ -1,6 +1,7 @@
 package client_test
 
 import (
+	"context"
 	"net/http"
 	"net/http/httptest"
 	"sync/atomic"
@@ -17,7 +18,7 @@ func TestUnit_OAuth2TokenSource(t *testing.T) {
 		}
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte(`{"access_token":"test-access-token","expires_in":3600,"token_type":"Bearer"}`))
+		_, _ = w.Write([]byte(`{"access_token":"test-access-token","expires_in":3600,"token_type":"Bearer"}`))
 	}))
 	defer srv.Close()
 
@@ -41,7 +42,7 @@ func TestUnit_OAuth2TokenSource_Caching(t *testing.T) {
 		atomic.AddInt32(&callCount, 1)
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte(`{"access_token":"cached-token","expires_in":3600,"token_type":"Bearer"}`))
+		_, _ = w.Write([]byte(`{"access_token":"cached-token","expires_in":3600,"token_type":"Bearer"}`))
 	}))
 	defer srv.Close()
 
@@ -76,7 +77,7 @@ func TestUnit_LoginWithAPIToken(t *testing.T) {
 	}))
 	defer srv.Close()
 
-	tok, err := client.LoginWithAPIToken(nil, srv.Client(), srv.URL, "my-api-token")
+	tok, err := client.LoginWithAPIToken(context.TODO(), srv.Client(), srv.URL, "my-api-token")
 	if err != nil {
 		t.Fatalf("LoginWithAPIToken(): %v", err)
 	}
@@ -89,7 +90,7 @@ func TestUnit_APIError_NotFound(t *testing.T) {
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusNotFound)
-		w.Write([]byte(`{"errors":[{"message":"file system not found"}]}`))
+		_, _ = w.Write([]byte(`{"errors":[{"message":"file system not found"}]}`))
 	}))
 	defer srv.Close()
 

internal/client/filesystems_test.go

@@ -445,20 +445,21 @@ func TestUnit_FileSystem_List_Paginated(t *testing.T) {
 		case r.Method == http.MethodGet && r.URL.Path == "/api/2.22/file-systems":
 			callCount++
 			token := r.URL.Query().Get("continuation_token")
-			if token == "" {
+			switch token {
+			case "":
 				// First page: return 2 items + continuation_token.
 				writeJSON(w, http.StatusOK, map[string]any{
 					"items":              page1,
 					"total_item_count":   3,
 					"continuation_token": "page2-token",
 				})
-			} else if token == "page2-token" {
+			case "page2-token":
 				// Second page: return 1 item, no token.
 				writeJSON(w, http.StatusOK, map[string]any{
 					"items":            page2,
 					"total_item_count": 3,
 				})
-			} else {
+			default:
 				http.Error(w, "unexpected continuation_token", http.StatusBadRequest)
 			}
 		default:

internal/client/transport.go

@@ -70,7 +70,7 @@ func (t *retryTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 
 		// Drain and close the response body before retrying to release the
 		// underlying TCP connection back to the pool.
-		io.Copy(io.Discard, resp.Body)
+		_, _ = io.Copy(io.Discard, resp.Body)
 		resp.Body.Close()
 
 		delay := t.computeDelay(attempt)

internal/provider/filesystem_resource_test.go

@@ -42,19 +42,6 @@ func resourceSchema(t *testing.T) resource.SchemaResponse {
 	return resp
 }
 
-// fsType returns the tftypes.Object for the full filesystem resource schema.
-// It is built from the actual schema so tests stay in sync automatically.
-func fsType(t *testing.T) tftypes.Object {
-	t.Helper()
-	s := resourceSchema(t).Schema
-	typ, err := s.Type().ApplyTerraform5AttributePathStep(nil)
-	_ = typ
-	_ = err
-	// Build a static tftypes.Object matching the schema — maintained manually
-	// but checked against the schema via compile-time model struct.
-	return buildFSType()
-}
-
 // buildFSType returns the tftypes.Object for filesystem_resource schema.
 func buildFSType() tftypes.Object {
 	spaceType := tftypes.Object{AttributeTypes: map[string]tftypes.Type{
@@ -203,16 +190,6 @@ func planWithName(t *testing.T, name string, provisioned int64) tfsdk.Plan {
 	}
 }
 
-// stateFromCreateResp builds a tfsdk.State from a Create response for Update/Delete tests.
-func stateFromPlan(t *testing.T, plan tfsdk.Plan) tfsdk.State {
-	t.Helper()
-	s := resourceSchema(t).Schema
-	return tfsdk.State{
-		Raw:    plan.Raw,
-		Schema: s,
-	}
-}
-
 // ---- tests ------------------------------------------------------------------
 
 // TestUnit_FileSystem_Create verifies Create populates ID and computed fields.

internal/provider/object_store_access_policy_rule_resource_test.go

@@ -208,8 +208,8 @@ func TestObjectStoreAccessPolicyRuleResource_Create(t *testing.T) {
 	if len(actions) != 2 {
 		t.Errorf("expected 2 actions, got %d", len(actions))
 	}
-	if model.Conditions.IsNull() {
-		// Expected null since no conditions provided
+	if !model.Conditions.IsNull() {
+		t.Error("expected conditions to be null since none were provided")
 	}
 }