Skip to content

Commit 578c505

Browse files
fix(WeightedAssessmentSurvey): Remove redundant sorting of scoring ranges
- Eliminated unnecessary sorting of scoring ranges by minimum value in multiple locations within the WeightedAssessmentSurveyWidget, improving code clarity and performance.
1 parent b5b97d7 commit 578c505

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

js/src/components/widgets/WeightedAssessmentSurveyWidget.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,6 @@ const WeightedAssessmentSurveyWidget: React.FC<WeightedAssessmentSurveyWidgetPro
246246
...updates
247247
};
248248

249-
// Sort ranges by min value
250-
group.scoringRanges.sort((a, b) => a.min - b.min);
251-
252249
setSurveyData(newData);
253250
};
254251

@@ -1377,9 +1374,6 @@ const WeightedAssessmentSurveyWidget: React.FC<WeightedAssessmentSurveyWidgetPro
13771374
...updates
13781375
};
13791376

1380-
// Sort ranges by min value
1381-
category.scoringRanges.sort((a, b) => a.min - b.min);
1382-
13831377
setSurveyData(updatedSurveyData);
13841378
};
13851379

@@ -1784,9 +1778,6 @@ const WeightedAssessmentSurveyWidget: React.FC<WeightedAssessmentSurveyWidgetPro
17841778
...updates
17851779
};
17861780

1787-
// Sort ranges by min value
1788-
updatedSurveyData.overallScoringRanges.sort((a, b) => a.min - b.min);
1789-
17901781
setSurveyData(updatedSurveyData);
17911782
};
17921783

0 commit comments

Comments
 (0)