[CS2103T-F09-2] JelphaBot #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please retitle the PR with the correct format. |
junhaotan
reviewed
Mar 26, 2020
|
|
||
| This section describes some noteworthy details on how certain features are implemented. | ||
|
|
||
| // tag::taskgroups[] |
There was a problem hiding this comment.
Lack of diagrams for added features. Good to have diagrams
junhaotan
reviewed
Mar 26, 2020
docs/DeveloperGuide.adoc
Outdated
|
|
||
| Given below is an example usage scenario and how the task grouping mechanism behaves at each step. | ||
|
|
||
| Step 1. The user launches the application for the first time. The `MainWindow` will be initialized with `GroupedTaskListPanel` as a container for GroupedTaskList model objects. The panel is populated with sublists defined in `GroupedByDateTaskList`. |
There was a problem hiding this comment.
Good to add screenshots in order to better understand the context of the usage scenario.
junhaotan
reviewed
Mar 26, 2020
junhaotan
left a comment
junhaotan
left a comment
There was a problem hiding this comment.
Generally, good effort on documentation. Just need to have more details in the added features.
docs/DeveloperGuide.adoc
Outdated
|
|
||
| ==== Implementation | ||
|
|
||
| **Function 1: Display calendar view in a selected month** |
There was a problem hiding this comment.
Good to add more explanation in the features.
… into walking-skeleton
… into walking-skeleton
update DG diagrams
Signed-off-by: Thng Yao Jie <[email protected]>
Updated some explanations in DG section
… into walking-skeleton
clear command now clears reminder
update DG and sampleDataUtil
… into walking-skeleton
reminder index fromOneBased ? fromZeroBased
corrected reminder index
update Ui
updated screenshots of Ui for UG
Update README and main window size
Fixed FXML warnings Signed-off-by: Thng Yao Jie <[email protected]>
Fixed FXML warnings Signed-off-by: Thng Yao Jie <[email protected]>
Signed-off-by: Thng Yao Jie <[email protected]>
Finalize UG and DG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.