-
Notifications
You must be signed in to change notification settings - Fork 262
Branch lc add find good function #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LiuChao93
wants to merge
314
commits into
nus-cs2103-AY1920S2:master
Choose a base branch
from
AY1920S2-CS2103-W14-2:Branch-LC-Add-Find-Good-Function
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Branch lc add find good function #176
LiuChao93
wants to merge
314
commits into
nus-cs2103-AY1920S2:master
from
AY1920S2-CS2103-W14-2:Branch-LC-Add-Find-Good-Function
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add GoodName class * Add GoodName tests * Add Good class * Add Good class tests * Remove unused good variable in typical goods. * Remove unused static and non-static variables for Typical Goods. * Add more test cases for Good and GoodName classes. * Update the summary for Good class * Add GoodQuantity class * Add GoodQuantity class test * Merge good quantity into good class * Add Good Information Ui and related FXML file * Add comment for the regex for good quantity. * Add UniqueGoodList and tests. * Add Ui for list of goods * Fix design choices and coding style errors. Co-authored-by: Daythehangedman <[email protected]>
* Add GoodName class * Add GoodName tests * Add Good class * Add Good class tests * Remove unused good variable in typical goods. * Remove unused static and non-static variables for Typical Goods. * Add more test cases for Good and GoodName classes. * Update the summary for Good class * Add GoodQuantity class * Add GoodQuantity class test * Merge good quantity into good class * Add Good Information Ui and related FXML file * Add comment for the regex for good quantity. * Add UniqueGoodList and tests. * Add Ui for list of goods * Add Inventory and related tests. * Add Json for Good and Inventory with relevant tests. * Resolve checkstyle errors on EOF in test file * Incorporate Inventory into Model. Updated related classes and tests during the incorporation. * Add GoodNameContainsKeywordsPredicateTest. * Update Logic Manager with method to obtain list of good. * Update GUI, split main window into two sub windows * Add more goods in the sample data. * Fix checkstyle error for trailing space in MainWindow.fxml * Fix design choices and coding style errors. Co-authored-by: Daythehangedman <[email protected]>
…models Refactor model classes
…cation-name-link Fix application name and links
Refactor naming of AddressBookParser to InventoryManagerParser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.