[CS2103T-W12-4] CookBuddy #36

AdarshChugani · 2020-02-19T04:14:08Z

No description provided.

syinyichen · 2020-03-04T04:52:22Z

docs/DeveloperGuide.adoc

+| Priority | Difficulty |                       As a…                       |                                      I can…                                      |                                So that…
+|        1 |          1 | Regular user                                      | add a recipe                                                                     | I can keep track of the recipe
+|        1 |          1 | Regular user                                      | delete a recipe                                                                  | stop keeping track of the recipe
+|        1 |          1 | Regular user                                      | list out all the recipies I have (names)                                         | easily see what recipies I have


Regular user is too broad, maybe u can try to specify the type of users

joel-lim

Good job with the use cases! Just a few minor changes

joel-lim · 2020-03-04T04:52:07Z

docs/DeveloperGuide.adoc

+*MSS*
+
+1.  `User` requests to delete a specific _recipe_ by specifying its name or index
+2.  CookBuddy deletes the recipe


CookBuddy should be in ``

joel-lim · 2020-03-04T04:53:26Z

docs/DeveloperGuide.adoc

+
+1. `User` requests to modify a recipe
+2. `CookBuddy` edits attributes of the recipe, and asks for user confirmation
+3. `User` confirms the edit


The MSS should end with "CookBuddy edits the attributes"

joel-lim · 2020-03-04T05:00:17Z

docs/DeveloperGuide.adoc

 *Extensions*

+[none]
+* 1a. The name cannot be found, or the index is invalid.


What name, and what index?

joel-lim · 2020-03-04T05:01:27Z

docs/DeveloperGuide.adoc

+Use case resumes at step 1.
+
 [none]
 * 2a. The list is empty.


This should be 1b rather than 2a

joel-lim · 2020-03-04T05:02:29Z

docs/DeveloperGuide.adoc

+=== Use case: Delete recipe
+
+*MSS*
+


Add the step for the user listing recipes first

syinyichen

Your user stories make sense though there are many repeats

wanxuanong · 2020-03-04T05:48:29Z

docs/DeveloperGuide.adoc

+| Priority | Difficulty |                       As a…                       |                                      I can…                                      |                                So that…
+|        1 |          1 | Regular user                                      | add a recipe                                                                     | I can keep track of the recipe
+|        1 |          1 | Regular user                                      | delete a recipe                                                                  | stop keeping track of the recipe
+|        1 |          1 | Regular user                                      | list out all the recipies I have (names)                                         | easily see what recipies I have


Is 'recipies' the correct spelling?

wanxuanong · 2020-03-04T05:52:34Z

docs/DeveloperGuide.adoc

 .  Should work on any <<mainstream-os,mainstream OS>> as long as it has Java `11` or above installed.
-.  Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.
+.  Should be able to hold up to 1000 recipes without noticeable sluggishness in performance for typical usage.
 .  A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.


You might want to state an NFR specific to your app instead of addressbook.
All NFRs are too generic.

wanxuanong · 2020-03-04T05:59:45Z

docs/DeveloperGuide.adoc

+|        5 |          4 | User who wants to challenge myself                | have a timer/stopwatch                                                           | time myself when I cook dishes and have a "best time" feature
+|        5 |          5 | User who doesn't like screens and prefers paper   | print recipes as pdf/paper                                                       | I can refer to it more easily
+|        5 |          5 | User who likes sharing my cooking                 | post my recipes and dishes on social media                                       | share recipes and images for others to use
+|        5 |          5 | User who appreciates efficiency                   | add a recipe directly from online                                                | I can be efficient


Is the reason 'so that I can be efficient' too vague?

chanckben · 2020-03-04T05:51:37Z

docs/DeveloperGuide.adoc

+
+*MSS*
+
+1.  `User` requests to delete a specific _recipe_ by specifying its name or index


Is this assuming the index of the recipe is already known? Perhaps you can list the recipes as part of MSS.

chanckben · 2020-03-04T05:54:17Z

docs/DeveloperGuide.adoc

+
+*MSS*
+
+1. `User` requests to modify a recipe


Should the user specify the name or index of the recipe here as well? Might be inconsistent with the other use cases.

chanckben · 2020-03-04T05:58:21Z

docs/DeveloperGuide.adoc

+[none]
+** `CookBuddy` throws an error message.
+
+Use case resumes at step 1.


Does this force the user to modify the recipe, e.g. if he requests to modify unintentionally but does not have new attributes to change? CookBuddy will just keep requesting the User to modify, resulting in an infinite loop.
Consider changing it to "Use case ends".

CharmaineKoh

Good job on following the address book developer guide rigorously!

don-tay

Good job with the architectural overview of the app.

don-tay · 2020-03-26T02:24:04Z

docs/DeveloperGuide.adoc


 .Architecture Diagram
-image::ArchitectureDiagram.png[]
+image::ArchitectureDiagram.svg[]


Sufficient level of detail at the architecture level. Good job!

don-tay · 2020-03-26T02:30:36Z

docs/DeveloperGuide.adoc


 .Class Diagram of the Logic Component
-image::LogicClassDiagram.png[]
+image::LogicClassDiagram.svg[]


Sufficient level of details for logic component.

don-tay · 2020-03-26T02:34:21Z

docs/DeveloperGuide.adoc


 .Structure of the UI Component
-image::UiClassDiagram.png[]
+image::UiClassDiagram.svg[]


Is this sufficient explanation? Should there be a one-liner description to direct us on aspects of the diagram?

…factor some test classes

…3T-W12-4/main into main-adarsh-tests

…-docs update linked docs to reflect CookBuddy instead of Address Book

Docs: update DG and UG

duplicate command activity and sequence diagram

update PPP

…2-CS2103T-W12-4/main into main-adarsh-updateReadme

Update PPP

Docs: Complete sharadhr PPP

…/main into main-zain * 'main-zain' of https://github.com/AY1920S2-CS2103T-W12-4/main: update DG & UG update DG, UG and PPP add manual tests for prep time and fav update Testing.adoc update DevOps.adoc update Documentation.adoc update SettingUp guide

… into main-zain * 'master' of https://github.com/AY1920S2-CS2103T-W12-4/main: remove parts of PPP Update PPP update PPP Fix checkstyle again Fix checkstyle Complete PPP fix checkstyple error, update ppp Update PPP Update PPP duplicate activity and sequence diagram Sharadh's PPP

Chore: update Ui.png

Update image which appears on Google

syinyichen reviewed Mar 4, 2020

View reviewed changes

joel-lim reviewed Mar 4, 2020

View reviewed changes

docs/DeveloperGuide.adoc

*Extensions*

[none]

* 1a. The name cannot be found, or the index is invalid.

Copy link

joel-lim Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What name, and what index?

joel-lim reviewed Mar 4, 2020

View reviewed changes

docs/DeveloperGuide.adoc

Use case resumes at step 1.

[none]

* 2a. The list is empty.

Copy link

joel-lim Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 1b rather than 2a

joel-lim reviewed Mar 4, 2020

View reviewed changes

docs/DeveloperGuide.adoc

=== Use case: Delete recipe

*MSS*

Copy link

joel-lim Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the step for the user listing recipes first

syinyichen reviewed Mar 4, 2020

View reviewed changes

wanxuanong reviewed Mar 4, 2020

View reviewed changes

chanckben reviewed Mar 4, 2020

View reviewed changes

kevinswk94 force-pushed the master branch from e1cb0c7 to 15356ce Compare March 10, 2020 11:05

CharmaineKoh reviewed Mar 26, 2020

View reviewed changes

don-tay reviewed Mar 26, 2020

View reviewed changes

muhd97 and others added 19 commits April 11, 2020 14:53

Chore: write test classes for imageutil and unique recipe list and re…

5d18345

…factor some test classes

Add test cases for new command

49d5527

Fix checkstyle issues

a3949e3

Merge branch 'main-adarsh-tests' of https://github.com/AY1920S2-CS210…

267bb54

…3T-W12-4/main into main-adarsh-tests

Add test cases for the reset command

d2e4c6e

Fix checkstyle issues related to import

771fd04

Fix: unique recipe list test and do some refactoring

3414973

Add test cases for help command

7bfd949

Fix: imageutil test

9404088

Fix: checkstyle issues

764fa00

Added test cases for fav command

4683de6

Fix Checkstyle issues

4bad89f

Add test cases for unfav command

ecc6dff

Fix checkstyle issues

4f6e172

Add test cases for done command

9ba1c44

Refact: Image to Photograph

5bdbf27

Chore: write deleteCommandParserTest

16446d2

Fix checkstyle issues

d9c945d

Add test cases for Undo command

052e46a

muhd97 and others added 30 commits April 13, 2020 22:33

Fix: travis issues

9ef7941

Merge pull request #314 from AY1920S2-CS2103T-W12-4/main-kevin-linked…

150cc38

…-docs update linked docs to reflect CookBuddy instead of Address Book

Merge branch 'master' into main-zain

6f25c7f

Complete PPP

9b30a45

Merge branch 'master' into main-sharadh

bc2c8f2

Fix checkstyle

cdefb8a

Merge pull request #328 from AY1920S2-CS2103T-W12-4/main-zain

39d4215

Docs: update DG and UG

Merge branch 'master' into main-mingsi-docs

73b3dcb

Merge branch 'master' into main-sharadh

881bfbf

Fix checkstyle again

d4191e6

update PPP

93949b5

Merge branch 'master' into main-kevin-PPP

942e0a3

Update PPP

3f30f76

Merge pull request #326 from AY1920S2-CS2103T-W12-4/main-mingsi-docs

96b3659

duplicate command activity and sequence diagram

Merge branch 'master' into main-adarsh-updateReadme

1067086

Merge branch 'master' into main-kevin-PPP

6ea99a0

Merge branch 'master' into main-sharadh

971a4c1

Merge pull request #330 from AY1920S2-CS2103T-W12-4/main-kevin-PPP

57b9381

update PPP

Merge branch 'master' into main-adarsh-updateReadme

6426db6

remove parts of PPP

68a7321

Merge branch 'main-adarsh-updateReadme' of https://github.com/AY1920S…

00dbb82

…2-CS2103T-W12-4/main into main-adarsh-updateReadme

Update PPP

e0792d4

Update PPP

Merge branch 'master' into main-sharadh

777f88f

Merge pull request #329 from AY1920S2-CS2103T-W12-4/main-sharadh

483b222

Docs: Complete sharadhr PPP

Chore: update Ui.png

e517d22

Merge pull request #332 from AY1920S2-CS2103T-W12-4/main-zain

044513e

Chore: update Ui.png

Update image which appears on Google

9382d46

Merge pull request #334 from AY1920S2-CS2103T-W12-4/main-adarsh

b3e8374

Update image which appears on Google


		MSS

		1. `User` requests to delete a specific _recipe_ by specifying its name or index

[CS2103T-W12-4] CookBuddy #36

Are you sure you want to change the base?

[CS2103T-W12-4] CookBuddy #36

Uh oh!

Conversation

AdarshChugani commented Feb 19, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joel-lim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

syinyichen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CharmaineKoh left a comment

Choose a reason for hiding this comment

Uh oh!

don-tay left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants