Skip to content

Conversation

@junhaotan
Copy link

@junhaotan junhaotan commented Feb 19, 2020

Team PR
@YingxuH
@aliciatxl

Copy link

@zhuhanming zhuhanming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do see below for our feedback. Keep it up!

_{More to be added}_
|`*` |lazy user |keep track of previous inputs |enter/edit previous commands easily

|`*` |lazy user |access <<product, products>> that are running low easily |restock and update the system much faster

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but what exactly does "access products that are running low" mean? Not very sure.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can rephrase as "List products that are running low".


|`* *` |user |set the inventory quantity low limit |get notified when my stock is running low

|`* *` |user |view the top-selling <<product, products>> and worst-selling <<product, products>> at one glance (e.g. dashboard that displays name of <<product, products>>) |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite similar to the "view a list of products sorted by the amount of sales" below. Perhaps make it clearer that this is more UI-focused?


[none]
* 2a. The list is empty.
+

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can add a line on how the application will handle this special case.

|=======================================================================

[appendix]
== Use Cases

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All use cases are missing preconditions, guarantees etc. Would be good to add more information.

3. User requests to delete a specific person in the list
4. AddressBook deletes the person
1. User requests to list items.
2. The app displays a list of requested items.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This listing functionality is already under UC05 below. Should reference it.


1. User requests to view statistics.
2. The app shows all statistics.
3. User requests to predict sales for next month.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a separate use case, as sales prediction is quite a big use case, and may have quite a few extensions..

YingxuH and others added 29 commits March 29, 2020 19:18
Delete transactions with product when product is deleted
Update UG and sort Products by remaining balance automatically
Delete transactions with customer when customer is deleted, fix stats…
Updated styling of StatisticsListPanel with CSS
Update stats window ui, fix edit transaction
junhaotan and others added 30 commits April 13, 2020 15:29
Fix jar file from throwing NPE due to invalid path name
# Conflicts:
#	src/main/java/seedu/address/logic/parser/customer/AddCustomerCommandParser.java
add transaction command parser test
Rename YingxuH.adoc to yingxuh.adoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants