[CS2103T-F10-3] NOVA #45

BryanYap972 · 2020-02-20T12:57:16Z

@huixianc @lohszeying @mightyrabbit99 @xCelestialPhoenix @BryanYap972

* update AboutUs * update AboutUs * update ContactUs * update readme * Fix checkstyle violations Co-authored-by: Nicholas Cristian Fernando <[email protected]>

heidicrq

Great job in general.

heidicrq · 2020-03-06T02:39:03Z

docs/DeveloperGuide.adoc

+|`* *` |student |add contact information on CS2103T professors |can contact them
+
+|`* * *` |student |create meeting events | can keep track of my schedule
+


User stories are not sorted by priority.

heidicrq · 2020-03-06T02:46:06Z

docs/DeveloperGuide.adoc

+|`* * *` |student |create study session events | can keep track of my schedule
+
+|`* * *` |student |create consultation events | can keep track of my schedule
+


Same benefit. Can add more details or be more specific about the benefits.

heidicrq · 2020-03-06T02:47:07Z

docs/DeveloperGuide.adoc

+.  The application should respond to every command within one second.
+.  Technical requirements: The application should work on both 32-bit and 64-bit environments.


Not app specific.

zixinn

Great job!

zixinn · 2020-03-06T02:39:37Z

docs/DeveloperGuide.adoc

+
+|`* * *` |student |delete classmate or teammate’s contact |delete if not necessary anymore
+
+|`* * *` |student |categorise contacts into teammate or classmate |


Missing benefit for user story

zixinn · 2020-03-06T02:47:05Z

docs/DeveloperGuide.adoc

 _{More to be added}_

 [appendix]
 == Non Functional Requirements


NFR not app-specific

zixinn · 2020-03-06T02:51:28Z

docs/DeveloperGuide.adoc

 _{More to be added}_

 [appendix]
 == Glossary


Important terms missing, e.g. CLI, GUI

alushingg

Good job

alushingg · 2020-03-06T02:41:42Z

docs/DeveloperGuide.adoc

+
+|`* * *` |student |edit profile picture to added contact |edit the picture if changes are necessary
+
+|`* * *` |student |delete profile picture to added contact|


Missing benefit

alushingg · 2020-03-06T02:51:32Z

docs/DeveloperGuide.adoc

 _{More to be added}_

 [appendix]
 == Glossary


Maybe can add a glossary for MSS, Extensions

NNpanpan

Nice job, guys!

NNpanpan · 2020-03-06T02:43:44Z

docs/DeveloperGuide.adoc

+
+|`* * *` |student |delete profile picture to added contact|
+
+|`* * *` |student |add category specific description |filter out a contact’s remark according to type of contact


"Category specific" - Should clarify which objects' categories that are mentioned

NNpanpan · 2020-03-06T02:44:30Z

docs/DeveloperGuide.adoc

+
+|`* * *` |student |create lesson events | can keep track of my schedule
+
+|`* * *` |student |note down the location of the meeting | know where to go


What does "note down" mean in this system?

NNpanpan · 2020-03-06T02:52:25Z

docs/DeveloperGuide.adoc

-.  Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.
 .  A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.
+.  The application should respond to every command within one second.
+.  Technical requirements: The application should work on both 32-bit and 64-bit environments.


Given that almost all personal computers are running 64-bit OSes, is this a necessary constraint?

dinhnhobao · 2020-03-06T02:44:10Z

docs/DeveloperGuide.adoc

+|`* * *` |student |create meeting events | can keep track of my schedule
+
+|`* * *` |student |create study session events | can keep track of my schedule
+
+|`* * *` |student |create consultation events | can keep track of my schedule
+
+|`* * *` |student |create lesson events | can keep track of my schedule


It would better if the "so that I..." part is more descriptive and detailed. This can help us to show that the user stories/features provided are very useful and specific for the target user.

dinhnhobao · 2020-03-06T02:53:03Z

docs/DeveloperGuide.adoc

+
+|`* * *` |student |find events | can check if I have any specific events according to keyword(s)
+
+|`* *` |student |add notes to events | can jot down additional details about the events


It would be useful to elaborate "jot down additional details" so as it's clearer as a benefit.

dinhnhobao

Well done!

teriaiw · 2020-03-27T01:35:22Z

docs/DeveloperGuide.adoc

 .  In addition, the `CommandResult` object can also instruct the `Ui` to perform certain actions, such as displaying help to the user.

-Given below is the Sequence Diagram for interactions within the `Logic` component for the `execute("delete 1")` API call.
+Given below is the Sequence Diagram for interactions within the `Logic` component for the `execute("done t\2020-03-20 i\2")` API call.


This sequence diagram looks too complicated. Perhaps you could abstract out some of the information and create another separate sequence diagram such that each diagram contains lesser and more relevant information.

teriaiw · 2020-03-27T01:40:04Z

docs/DeveloperGuide.adoc

+
+5. `Model#markDone()` is called, and the `Schedule` object in `ModelManager` is updated.
+
+The following sequence diagram shows how the mark event as done operation works:


This diagram is repetitive and does not provide additional information.

nathanaelseen · 2020-03-27T01:34:35Z

docs/DeveloperGuide.adoc


 *API* :
-link:{repoURL}/src/main/java/seedu/address/logic/Logic.java[`Logic.java`]
+link:{repoURL}/src/main/java/seedu/nova/logic/Logic.java[`Logic.java`]


The same diagram is duplicated above, in the higher-level description of the app's architecture. Perhaps a simpler and more abstract diagram could be used to describe the higher-level summary of Logic (and you can leave the more detailed diagram of Logic here)

but I think its good that you provided some notes for the XYZCommand (in the class diagram)

yjskrs · 2020-03-27T01:31:35Z

docs/DeveloperGuide.adoc

@@ -1,8 +1,9 @@
-= AddressBook Level 3 - Developer Guide
+= NOVA - Developer Guide


The uml diagrams are not consistent - one is just white boxes but the other is white box highlighted with red lines. Maybe can make them all just non-highlight or make them all highlighted with different colours

yjskrs · 2020-03-27T01:34:47Z

docs/DeveloperGuide.adoc

 === Model component

 .Structure of the Model Component
 image::ModelClassDiagram.png[]


What is the empty box between person and email and category?

New master

… into branch-PPP # Conflicts: # docs/team/huixianc.adoc

… into branch-UG

… into branch-DG

Replaced Ui.png with Windows version

Updated links for PRs

DG: Fixed broken link in DG for Main.java and MainApp.java, Updated Ui.png Windows ver (with black border)

Fixed spaces in error message

* 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main: updated dg updated dg Fixed progress calculation. fixed spaces in error message fixed spaces in error message

Update UserGuide.adoc

Edited Ui.png again, UG change: Changed team name (removed "Team" in front)

edited error messages

Edited UG: Command Summary to include Bryan's name

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

Edited error message

Change to 1.4.0 in MainApp.java

heidicrq reviewed Mar 6, 2020

View reviewed changes

zixinn reviewed Mar 6, 2020

View reviewed changes

alushingg reviewed Mar 6, 2020

View reviewed changes

NNpanpan reviewed Mar 6, 2020

View reviewed changes

dinhnhobao reviewed Mar 6, 2020

View reviewed changes

xCelestialPhoenix force-pushed the master branch from 1ad4b58 to e7d3dbe Compare March 11, 2020 11:20

teriaiw reviewed Mar 27, 2020

View reviewed changes

nathanaelseen reviewed Mar 27, 2020

View reviewed changes

yjskrs reviewed Mar 27, 2020

View reviewed changes

mightyrabbit99 and others added 19 commits April 12, 2020 13:50

delete unwanted file

8378ba8

csT

2d2516e

docthor

8b1b542

Merge pull request #407 from mightyrabbit99/new-master

81f6896

New master

Updated UG for progress tracker

3e467ed

added tags

5224ef0

added tags

379f5c7

added tests for event methods in schedule

7078118

fix checkstyle

6c7f858

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main

0403937

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main…

1865d3d

… into branch-PPP # Conflicts: # docs/team/huixianc.adoc

Updated UG for progress tracker

263117a

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main…

28899d2

… into branch-UG

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main…

472eb37

… into branch-DG

Updated PPP and added tags in user guide

29e9248

Updated PPP to reference developer guide

d3b7037

Removed PPP generated PDF

a015061

Added tags for PPP

23cbe19

Removed PPP generated PDF

ffc9eca

BryanYap972 and others added 30 commits April 13, 2020 21:54

fixed spaces in error message

73b6679

Merge pull request #470 from lohszeying/master

fc42ed9

Replaced Ui.png with Windows version

Update links to PR

103ff65

Fixed broken link in DG for Main.java and MainApp.java

ac466c1

Merge pull request #472 from xCelestialPhoenix/branch-portfolio

ef4c983

Updated links for PRs

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main

b78cec3

Added black border to Ui.png (following Terence's style)

281e06e

Fixed progress calculation.

b35291b

Merge pull request #473 from lohszeying/master

0c102a5

DG: Fixed broken link in DG for Main.java and MainApp.java, Updated Ui.png Windows ver (with black border)

updated dg

ae36871

updated dg

8a42cc5

Merge pull request #471 from BryanYap972/master

b531ecf

Fixed spaces in error message

Edited Ui.png again

b18dc27

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main

ffd6eb2

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main

8480267

* 'master' of https://github.com/AY1920S2-CS2103T-F10-3/main: updated dg updated dg Fixed progress calculation. fixed spaces in error message fixed spaces in error message

updated ug

72daf92

Update UserGuide.adoc

fa63bf8

Merge pull request #476 from AY1920S2-CS2103T-F10-3/BryanYap972-patch-3

1814dc5

Update UserGuide.adoc

UG Change: By CS2103T-F10-3 from Team CS2103T-F10-3

391587b

Merge pull request #474 from lohszeying/master

106ba05

Edited Ui.png again, UG change: Changed team name (removed "Team" in front)

edited error messages

64098c5

Merge pull request #477 from huixianc/master

0ad9c1e

edited error messages

Edited UG: Command Summary to include Bryan's name

234c4f7

Merge pull request #478 from lohszeying/master

c5c7120

Edited UG: Command Summary to include Bryan's name

updated ug

894383f

Edited error message

d080239

Merge pull request #479 from BryanYap972/master

9ebf1be

Edited error message

Change to 1.4.0 in MainApp.java

e32d24c

Merge pull request #480 from lohszeying/master

4dd1175

Change to 1.4.0 in MainApp.java

		\|`* *` \|student \|add contact information on CS2103T professors \|can contact them

		\|`* * *` \|student \|create meeting events \| can keep track of my schedule

		\|`* * *` \|student \|create study session events \| can keep track of my schedule

		\|`* * *` \|student \|create consultation events \| can keep track of my schedule

		. The application should respond to every command within one second.
		. Technical requirements: The application should work on both 32-bit and 64-bit environments.


		\|`* * *` \|student \|delete classmate or teammate’s contact \|delete if not necessary anymore

		\|`* * *` \|student \|categorise contacts into teammate or classmate \|


		\|`* * *` \|student \|edit profile picture to added contact \|edit the picture if changes are necessary

		\|`* * *` \|student \|delete profile picture to added contact\|


		\|`* * *` \|student \|delete profile picture to added contact\|

		\|`* * *` \|student \|add category specific description \|filter out a contact’s remark according to type of contact


		\|`* * *` \|student \|create lesson events \| can keep track of my schedule

		\|`* * *` \|student \|note down the location of the meeting \| know where to go


		\|`* * *` \|student \|find events \| can check if I have any specific events according to keyword(s)

		\|`* *` \|student \|add notes to events \| can jot down additional details about the events


		5. `Model#markDone()` is called, and the `Schedule` object in `ModelManager` is updated.

		The following sequence diagram shows how the mark event as done operation works:

		@@ -1,8 +1,9 @@
		= AddressBook Level 3 - Developer Guide
		= NOVA - Developer Guide

[CS2103T-F10-3] NOVA #45

Are you sure you want to change the base?

[CS2103T-F10-3] NOVA #45

Uh oh!

Conversation

BryanYap972 commented Feb 20, 2020

Uh oh!

heidicrq left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zixinn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alushingg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NNpanpan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dinhnhobao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants