[CS2103T-W16-4] NusProductivity #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyt-sonia
reviewed
Mar 4, 2020
Comment on lines
+374
to
+377
| 1. User requests to show module plan | ||
| 2. AddressBook shows module plan | ||
| 3. User requests to delete a module taken | ||
| 4. AddressBook deletes module |
There was a problem hiding this comment.
This use case looks nice.
How about if we add the response of the server as:
5. the AddressBook displays the updated module list after successful deletion.
aegis-bot
reviewed
Mar 4, 2020
docs/DeveloperGuide.adoc
Outdated
Comment on lines
317
to
329
| |`* *` |user |add diary entry |record what I have done for the day | ||
|
|
||
| |`* *` |user |delete diary entry | | ||
|
|
||
| |`* *` |user |show diary entry list | | ||
|
|
||
| |`* *` |user |delete module from module plan |know which modules I have taken | ||
|
|
||
| |`* *` |user |fetch module information | | ||
|
|
||
| |`* *` |user |know current CAP | | ||
|
|
||
| |`* *` |user |sort deadlines |prioritize which tasks to finish first |
There was a problem hiding this comment.
Users could be more specific like
students
student who suck at time managements
student who wants to improve his grades
could be more specific
souwmyaa
reviewed
Mar 4, 2020
docs/DeveloperGuide.adoc
Outdated
| . Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage. | ||
| . A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse. | ||
| . Should respond within 2 seconds | ||
| . Should be easy to use for users who are not IT-savvy |
Member
There was a problem hiding this comment.
This NFR's testability seems a little ambiguous. Maybe you could add a few details
teikjun
reviewed
Mar 4, 2020
docs/DeveloperGuide.adoc
Outdated
| . Should work on any <<mainstream-os,mainstream OS>> as long as it has Java `11` or above installed. | ||
| . Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage. | ||
| . A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse. | ||
| . Should respond within 2 seconds |
There was a problem hiding this comment.
I think you could be more specific about which commands you are referring to, since different commands may have different expected respond times. I think this will improve the testability of this NFR
| . A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse. | ||
| . Should respond within 2 seconds | ||
| . Should be easy to use for users who are not IT-savvy | ||
| . User should be a current student in NUS |
There was a problem hiding this comment.
You could consider adding NUS to glossary
…command and add in the functionality to delete tasks of certain module
moduleTask command and major command added
…there is a deadline and remove the dot once the deadline is over
Fixed build issues and upddated UG DG
Update User Guide
Update PPP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@watsheldon
@xuanxinng
@mpang45456
@Kangwkk