Fix encoding of VC ID while deleting

Author: reinkrul

web/src/admin/IdentityDetails.vue

@@ -116,6 +116,7 @@
 import DiscoveryServiceDefinition from "./DiscoveryServiceDefinition";
 import ErrorMessage from "../components/ErrorMessage.vue";
 import UploadCredential from "./credentials/UploadCredential.vue";
+import encodeURIPath from "../lib/encode.js"
 
 export default {
   components: {ErrorMessage, UploadCredential},
@@ -178,7 +179,7 @@ export default {
         return
       }
       this.fetchError = undefined
-      this.$api.delete(`api/proxy/internal/vcr/v2/holder/${encodeURIComponent(this.$route.params.subjectID)}/vc/${encodeURIComponent(credentialId)}`)
+      this.$api.delete(`api/proxy/internal/vcr/v2/holder/${encodeURIPath(this.$route.params.subjectID)}/vc/${encodeURIPath(credentialId)}`)
           .then(data => {
             if (data.reason) {
               this.fetchError = data.reason

web/src/lib/encode.js

@@ -0,0 +1,6 @@
+export default {
+    // encodeURIPath is like encodeURI, but does not encode :
+    // Reason for this, is that Verifiable Credential IDs (VC IDs) are URIs that contain colons, which don't need to be encoded in URI paths,
+    // but are encoded by encodeURI. This breaks API usage in Go, because Echo (or Go's HTTP package) does not decode the colons in the path, leading to 404 errors when trying to access VC IDs
+    encodeURIPath: (path) => encodeURI(path).replace(/%3A/g, ':')
+}