Bump golang from 1.23.6-alpine to 1.24.0-alpine (#3699) (#3721)

* Bump golang from 1.23.6-alpine to 1.24.0-alpine

Bumps golang from 1.23.6-alpine to 1.24.0-alpine.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...



* update go.mod

* fix new requirements

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: gerardsn

Dockerfile

@@ -1,5 +1,5 @@
 # golang alpine
-FROM golang:1.23.6-alpine AS builder
+FROM golang:1.24.0-alpine AS builder
 
 ARG TARGETARCH
 ARG TARGETOS

auth/services/oauth/authz_server_test.go

@@ -574,7 +574,9 @@ func TestService_parseAndValidateJwtBearerToken(t *testing.T) {
 	})
 
 	t.Run("wrong signing algorithm", func(t *testing.T) {
-		privateKey, _ := rsa.GenerateKey(rand.Reader, 512)
+		t.Setenv("GODEBUG", "rsa1024min=0") // minimum key-length has changed to 1024 -> https://pkg.go.dev/crypto/rsa#hdr-Minimum_key_size
+		privateKey, err := rsa.GenerateKey(rand.Reader, 512)
+		require.NoError(t, err)
 
 		keyID := "did:nuts:somedid#key-id"
 

go.mod

@@ -2,7 +2,7 @@ module github.com/nuts-foundation/nuts-node
 
 // This is the minimal version, the actual go version is determined by the images in the Dockerfile
 // This version is used in automated tests such as the 'Scheduled govulncheck' action
-go 1.23.6
+go 1.24.0
 
 require (
 	github.com/Azure/azure-sdk-for-go/sdk/azcore v1.16.0

makefile

@@ -7,7 +7,7 @@ install-tools:
 	go install google.golang.org/protobuf/cmd/[email protected]
 	go install go.uber.org/mock/[email protected]
 	go install google.golang.org/grpc/cmd/[email protected]
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
 
 gen-mocks:
 	mockgen -destination=auth/mock.go -package=auth -source=auth/interface.go

network/dag/notifier.go

@@ -383,10 +383,10 @@ func (p *notifier) retry(event Event) {
 				// logs after every failed attempt
 				if errors.Is(err, errEventIncomplete) {
 					// debug level if errEventIncomplete
-					p.logNotificationResponse(event, err, logrus.DebugLevel, "Retrying event (attempt %d/%d)", n, maxRetries)
+					p.logNotificationResponse(event, err, logrus.DebugLevel, fmt.Sprintf("Retrying event (attempt %d/%d)", n, maxRetries))
 				} else {
 					// error level for all other errors
-					p.logNotificationResponse(event, err, logrus.ErrorLevel, "Retrying event (attempt %d/%d)", n, maxRetries)
+					p.logNotificationResponse(event, err, logrus.ErrorLevel, fmt.Sprintf("Retrying event (attempt %d/%d)", n, maxRetries))
 				}
 			}),
 		)
@@ -397,12 +397,12 @@ func (p *notifier) retry(event Event) {
 	}(p.ctx)
 }
 
-func (p *notifier) logNotificationResponse(event Event, err error, level logrus.Level, msg string, args ...interface{}) {
+func (p *notifier) logNotificationResponse(event Event, err error, level logrus.Level, msg string) {
 	log.Logger().
 		WithError(err).
 		WithField(core.LogFieldTransactionRef, event.Hash.String()).
 		WithField(core.LogFieldEventSubscriber, p.name).
-		Logf(level, msg, args...)
+		Log(level, msg)
 }
 
 var errEventIncomplete = errors.New("receiver did not finish or fail")