WEBUI-1124 : Fix empty-label of nuxeo-favorites not appearing with POST page provider method [LTS-2025] (#3223)

* WEBUI-1124 : Fix empty-label of nuxeo-favorites not appearing with POST page provider method

- Reset page provider resultsCount and list state when no favorites collection exists
- Change favorites property type from Object to Array to match actual data shape
- Add unit tests for _refresh() behavior

* WEBUI-1124 : Explicitly set empty label to fix display on hard reload

The debounced _computeLabel in PageProviderDisplayBehavior does not reliably
set the empty label when the page provider was never fetched (POST method).
Directly assign _computedEmptyLabel on the data-list after reset.

* WEBUI-1124: fix empty label not appearing on hard reload

- Add [hidden] { display: none !important } to fix CSS specificity issue
  where .emptyResult { display: block } was overriding the hidden attribute
- Check favorites length after fetch to handle the case where the
  collection exists but is empty (all favorites removed)
- Add test for empty collection case

Author: madhurkulshrestha-hyland

elements/nuxeo-collections/nuxeo-favorites.js

@@ -39,10 +39,27 @@ import { handleVerticalKeyNavigation } from '../common-utils.js';
 Polymer({
   _template: html`
     <style include="nuxeo-styles">
+      :host([hidden]) {
+        display: none !important;
+      }
+
+      [hidden] {
+        display: none !important;
+      }
+
       .content {
         @apply --layout-vertical;
       }
 
+      .emptyResult {
+        opacity: 0.8;
+        display: block;
+        font-weight: 300;
+        padding: 1.5em 0.7em;
+        text-align: center;
+        font-size: 1.1em;
+      }
+
       nuxeo-data-list {
         display: block;
         position: relative;
@@ -132,6 +149,7 @@ Polymer({
       <h5>[[i18n('app.favorites')]]</h5>
     </div>
     <div class="content">
+      <div class="emptyResult" hidden$="[[!_noFavorites]]">[[i18n('favorites.empty')]]</div>
       <nuxeo-data-list
         nx-provider="favoritesProvider"
         id="favoritesList"
@@ -142,6 +160,7 @@ Polymer({
         as="favorite"
         empty-label="[[i18n('favorites.empty')]]"
         empty-label-when-filtered="[[i18n('favorites.empty')]]"
+        hidden$="[[_noFavorites]]"
       >
         <template>
           <div tabindex="0" class$="[[_computedClass(selected)]]" on-keydown="_handleKeyNav">
@@ -174,9 +193,13 @@ Polymer({
 
   properties: {
     favorites: {
-      type: Object,
+      type: Array,
       notify: true,
     },
+    _noFavorites: {
+      type: Boolean,
+      value: false,
+    },
     selectedFavorite: {
       type: Object,
       observer: '_selectedFavoriteChanged',
@@ -200,13 +223,16 @@ Polymer({
   },
 
   _refresh() {
-    this._fetchFavorite().then((favorite) => {
+    return this._fetchFavorite().then((favorite) => {
       if (!favorite) {
+        this._noFavorites = true;
         return;
       }
       this.$.favoritesProvider.params = [favorite.uid];
       this.$.favoritesProvider.page = 1;
-      this.$.favoritesList.fetch();
+      return this.$.favoritesList.fetch().then(() => {
+        this._noFavorites = !this.favorites || this.favorites.length === 0;
+      });
     });
   },
 

test/nuxeo-favorites.test.js

@@ -93,6 +93,50 @@ suite('nuxeo-favorites', () => {
     });
   });
 
+  suite('_refresh', () => {
+    test('should set _noFavorites to true when no favorite collection exists', async () => {
+      sinon.stub(element, '_fetchFavorite').resolves(null);
+      await element._refresh();
+      expect(element._noFavorites).to.be.true;
+    });
+
+    test('should set _noFavorites to false when favorite collection has items', async () => {
+      element._noFavorites = true;
+      const fav = { uid: 'fav-collection-1' };
+      sinon.stub(element, '_fetchFavorite').resolves(fav);
+      sinon.stub(element.$.favoritesList, 'fetch').callsFake(() => {
+        element.favorites = [{ uid: 'doc1' }];
+        return Promise.resolve();
+      });
+      await element._refresh();
+      expect(element._noFavorites).to.be.false;
+      expect(element.$.favoritesProvider.params).to.deep.equal([fav.uid]);
+      expect(element.$.favoritesProvider.page).to.equal(1);
+      expect(element.$.favoritesList.fetch).to.have.been.calledOnce;
+    });
+
+    test('should set _noFavorites to true when favorite collection exists but is empty', async () => {
+      element._noFavorites = false;
+      const fav = { uid: 'fav-collection-1' };
+      sinon.stub(element, '_fetchFavorite').resolves(fav);
+      sinon.stub(element.$.favoritesList, 'fetch').callsFake(() => {
+        element.favorites = [];
+        return Promise.resolve();
+      });
+      await element._refresh();
+      expect(element._noFavorites).to.be.true;
+      expect(element.$.favoritesProvider.params).to.deep.equal([fav.uid]);
+      expect(element.$.favoritesProvider.page).to.equal(1);
+    });
+
+    test('should not call fetch on list when favorite is null', async () => {
+      sinon.stub(element, '_fetchFavorite').resolves(null);
+      const fetchSpy = sinon.spy(element.$.favoritesList, 'fetch');
+      await element._refresh();
+      expect(fetchSpy).to.not.have.been.called;
+    });
+  });
+
   suite('_removeFromFavorites', () => {
     test('should execute operation and fire event', async () => {
       const stub = sinon.stub(element.$.removeFromFavOp, 'execute').resolves();