Skip to content

The isRelativeUrl check doesn't allow url with '=' #1880

Open
@GMartigny

Description

@GMartigny

Version

module: 5.0.0-1667386184.dfbbb54
nuxt: 2.16

What is expected?

When user load an URL without being logged in, a cookie is set to redirect once logged in.

What is actually happening?

Cookie is not set when URL contains = (an certainly other valid characters)

Steps to reproduce

  • Log out
  • Navigate to /my-files/TmV2ZXIgZ29ubmEgbGV0IHlvdSBkb3duICE=
  • Redirected to /login as expected
  • Check that cookie auth.redirect is not set

Additional information

This is due to the isRelativeURL function not accepting =. This should be rework and use a battle-tested library (is-relative) instead of a random regex.

Checklist

  • I have tested with the latest Nuxt version and the issue still occurs
  • I have tested with the latest module version and the issue still occurs
  • I have searched the issue tracker and this issue hasn't been reported yet

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions