chore: additional font safe guards, remove fs paths

Author: harlan-zw

src/module.ts

@@ -1,5 +1,6 @@
 import * as fs from 'node:fs'
 import { readFile } from 'node:fs/promises'
+import { existsSync } from 'node:fs'
 import {
   type AddComponentOptions,
   addComponent,
@@ -293,14 +294,25 @@ export default defineNuxtModule<ModuleOptions>({
           }
         }
         else if (f.path) {
+          // validate the extension, can only be woff, ttf or otf
+          const extension = basename(f.path).split('.').pop()!
+          if (!['woff', 'ttf', 'otf', 'base64'].includes(extension)) {
+            logger.warn(`The ${f.name}:${f.weight} font was skipped because the file extension ${extension} is not supported. Only woff, ttf and otf are supported.`)
+            return false
+          }
           // resolve relative paths from public dir
           if (!isAbsolute(f.path)) {
             // move to assets folder as base64 and set key
             f.path = join(nuxt.options.rootDir, nuxt.options.dir.public, f.path)
           }
+          if (!existsSync(f.path)) {
+            logger.warn(`The ${f.name}:${f.weight} font was skipped because the file does not exist at path ${f.path}.`)
+            return false
+          }
           const fontData = await readFile(f.path, 'base64')
           f.key = `nuxt-og-image:fonts:${f.name}-${f.weight}.ttf.base64`
           await fontStorage.setItem(`${basename(f.path)}.base64`, fontData)
+          delete f.path
         }
         return f
       }))).filter(Boolean) as InputFontConfig[]

src/runtime/nitro/routes/image.ts

@@ -20,8 +20,6 @@ export default defineEventHandler(async (e): Promise<any> => {
       compatibilityHints.push('Converting PNGs to JPEGs requires Sharp which only runs on Node based systems.')
     if (options.renderer === 'chromium')
       compatibilityHints.push('Using Chromium to generate images is only supported in Node based environments. It\'s recommended to only use this if you\'re prerendering')
-    if (options.component !== 'PageScreenshot' && await applyInlineCss(ctx, await fetchIsland(ctx)))
-      compatibilityHints.push('Inlining CSS is not supported on Cloudflare.')
     setHeader(e, 'Content-Type', 'application/json')
     return {
       siteConfig: {

test/integration/endpoints/debug.test.ts

@@ -40,17 +40,15 @@ describe('debug', () => {
               "cacheKey": "Inter:400",
               "key": "nuxt-og-image:fonts:Inter-400.ttf.base64",
               "name": "Inter",
-              "path": "",
               "style": "normal",
-              "weight": "400",
+              "weight": 400,
             },
             {
               "cacheKey": "Inter:700",
               "key": "nuxt-og-image:fonts:Inter-700.ttf.base64",
               "name": "Inter",
-              "path": "",
               "style": "normal",
-              "weight": "700",
+              "weight": 700,
             },
           ],
           "hasNuxtIcon": false,

test/integration/endpoints/fonts.test.ts

@@ -14,7 +14,7 @@ describe('fonts', () => {
       Blob {
         Symbol(kHandle): Blob {},
         Symbol(kLength): 310808,
-        Symbol(kType): "",
+        Symbol(kType): "font/ttf",
       }
     `)
   }, 60000)