fix: respect charset in response

Author: danielroe

packages/nuxt-cli/src/commands/curl.ts

@@ -277,14 +277,28 @@ async function writeResponseBody(response: Response, pretty: boolean): Promise<v
     return
   }
 
-  const text = buffer.toString('utf-8')
+  const text = decodeBody(buffer, contentType)
   const body = renderer?.(text) ?? text
   process.stdout.write(body)
   if (!body.endsWith('\n')) {
     process.stdout.write('\n')
   }
 }
 
+/** Decode with the charset the response declares, falling back to UTF-8 when it is absent or unknown. */
+function decodeBody(buffer: Buffer, contentType: string): string {
+  const charset = /;\s*charset=["']?([\w-]+)/i.exec(contentType)?.[1]
+  if (charset) {
+    try {
+      return new TextDecoder(charset).decode(buffer)
+    }
+    catch {
+      // fall through to UTF-8
+    }
+  }
+  return buffer.toString('utf-8')
+}
+
 /**
  * A content type we can render, or one matching `TEXT_CONTENT_TYPE_RE`, is
  * trusted outright; anything else is sniffed for a NUL byte, which no valid

packages/nuxt-cli/test/unit/commands/curl.spec.ts

@@ -64,6 +64,12 @@ const server = createServer(async (req, res) => {
     return
   }
 
+  if (req.url === '/latin1') {
+    res.setHeader('content-type', 'text/plain; charset=iso-8859-1')
+    res.end(Buffer.from('café', 'latin1'))
+    return
+  }
+
   if (req.url === '/binary') {
     res.setHeader('content-type', 'application/octet-stream')
     res.end(BINARY_BODY)
@@ -305,6 +311,12 @@ describe('curl', () => {
     expect(stripVTControlCharacters(stdout)).toBe('<urlset>\n  <url>\n    <loc>/</loc>\n  </url>\n</urlset>\n')
   })
 
+  it('decodes the body with the charset the response declares', async () => {
+    process.stdout.isTTY = true
+    expect(await run([`${origin}/latin1`])).toBe(0)
+    expect(stdout).toBe('café\n')
+  })
+
   it('takes a text/plain body at its word, even when it looks like json', async () => {
     process.stdout.isTTY = true
     expect(await run([`${origin}/untyped`])).toBe(0)