fix(init,module,upgrade): validate response from consola.prompt (#687)

nuxt · Jan 17, 2025 · fd918e3 · fd918e3
1 parent 269dc9a
commit fd918e3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/packages/nuxi/src/commands/init.ts b/packages/nuxi/src/commands/init.ts
@@ -152,6 +152,11 @@ export default defineCommand({
         options: packageManagerOptions,
       })
 
+    if (!packageManagerOptions.includes(selectedPackageManager)) {
+      logger.error('Invalid package manager selected.')
+      process.exit(1)
+    }
+
     // Install project dependencies
     // or skip installation based on the '--no-install' flag
     if (ctx.args.install === false) {
@@ -183,7 +188,7 @@ export default defineCommand({
     if (ctx.args.gitInit === undefined) {
       ctx.args.gitInit = await logger.prompt('Initialize git repository?', {
         type: 'confirm',
-      })
+      }) === true
     }
     if (ctx.args.gitInit) {
       logger.info('Initializing git repository...\n')

diff --git a/packages/nuxi/src/commands/module/add.ts b/packages/nuxi/src/commands/module/add.ts
@@ -145,7 +145,7 @@ async function addModules(modules: ResolvedModule[], { skipInstall, skipConfig,
         },
       )
 
-      if (res === false) {
+      if (res !== true) {
         return
       }
     }
@@ -268,6 +268,9 @@ async function resolveModule(moduleName: string, cwd: string): Promise<ModuleRes
               type: 'select',
               options: [_moduleVersion, pkgVersion],
             })
+            if (typeof pkgVersion !== 'string') {
+              return false
+            }
           }
           break
         }

diff --git a/packages/nuxi/src/commands/upgrade.ts b/packages/nuxi/src/commands/upgrade.ts
@@ -49,10 +49,10 @@ async function getNightlyVersion(packageNames: string[]): Promise<{ npmPackages:
     'Which nightly Nuxt release channel do you want to install? (3.x or 4.x)',
     {
       type: 'select',
-      options: ['3.x', '4.x'],
+      options: ['3.x', '4.x'] as const,
       default: '3.x',
     },
-  ) as '3.x' | '4.x'
+  )
 
   const nuxtVersion = typeof result === 'string' ? result : '3.x'
 
@@ -138,7 +138,7 @@ export default defineCommand({
           type: 'confirm',
           default: true,
         },
-      )
+      ) === true
     }
     if (ctx.args.force) {
       logger.info(