Skip to content

Commit 9899c51

Browse files
committed
change api networkname to appName n onMembersChange to onMembers
1 parent 7fb65c0 commit 9899c51

5 files changed

Lines changed: 15 additions & 15 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ CDN :
7979
import { createWebPEER } from 'webpeerjs'
8080
8181
const config = {
82-
networkName : 'myNetwork'
82+
appName : 'myAppHelloWorld'
8383
}
8484
8585
const peer = await createWebPEER();
@@ -107,7 +107,7 @@ Create a new peer node.
107107

108108
`config` - Configuration object contains:
109109

110-
- `networkName` - Unique identifier name of the network to build.
110+
- `appName` - Unique application name.
111111

112112
- `rtcConfiguration` - **(optional)** Custom [rtcConfiguration](https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/RTCPeerConnection) for WebRTC connection.
113113

@@ -128,7 +128,7 @@ Join to a room, returns an object.
128128

129129
- `room.sendMessage()` - Method to broadcast message to the room.
130130
- `romm.onMessage((message,peer_id)=>{})` - Listen on incoming broadcast message.
131-
- `room.onMembersChange((members)=>{})` - Listen on the room members update when a new peer is discovered or a peer is unreachable.
131+
- `room.onMembers((members)=>{})` - Listen on the room members update when a peer is join or leave.
132132

133133
## See Also
134134

demo/chat.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
});
166166

167167
const config = {
168-
networkName : 'p2pchat'
168+
appName : 'webpeer-p2p-chat'
169169
}
170170

171171
const peer = await createWebPEER();

demo/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
}
2828

2929
const config = {
30-
networkName : 'myNetwork'
30+
appName : 'myAppHelloWorld'
3131
}
3232

3333
const peer = await createWebPEER(config);

src/webpeer.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ class webpeerjs{
438438
if(!this.#rooms[room].members.includes(id)){
439439
if(this.#connectedPeers.has(id)){
440440
this.#rooms[room].members.push(id)
441-
this.#rooms[room].onMembers(this.#rooms[room].members)
441+
this.#rooms[room].onMembersUpdate(this.#rooms[room].members)
442442
}
443443
}
444444

@@ -465,7 +465,7 @@ class webpeerjs{
465465
if(!this.#rooms[room].members.includes(id)){
466466
if(this.#connectedPeers.has(id)){
467467
this.#rooms[room].members.push(id)
468-
this.#rooms[room].onMembers(this.#rooms[room].members)
468+
this.#rooms[room].onMembersUpdate(this.#rooms[room].members)
469469
}
470470
}
471471

@@ -883,7 +883,7 @@ class webpeerjs{
883883
return {
884884
sendMessage : this.#rooms[room].sendMessage,
885885
onMessage : this.#rooms[room].listenMessage,
886-
onMembersChange : this.#rooms[room].onMembersChange
886+
onMembers : this.#rooms[room].onMembers
887887
}
888888

889889

@@ -922,15 +922,15 @@ class webpeerjs{
922922
}
923923
},
924924
members : [this.id],
925-
onMembers : () => {},
926-
onMembersChange : f => {this.#rooms[room] = {...this.#rooms[room], onMembers: f};this.#rooms[room].onMembers(this.#rooms[room].members);this.#ping()},
925+
onMembersUpdate : () => {},
926+
onMembers : f => {this.#rooms[room] = {...this.#rooms[room], onMembersUpdate: f};this.#rooms[room].onMembersUpdate(this.#rooms[room].members);this.#ping()},
927927
}
928928
}
929929

930930
return {
931931
sendMessage : this.#rooms[room].sendMessage,
932932
onMessage : this.#rooms[room].listenMessage,
933-
onMembersChange : this.#rooms[room].onMembersChange
933+
onMembers : this.#rooms[room].onMembers
934934
}
935935
}
936936

@@ -1262,7 +1262,7 @@ class webpeerjs{
12621262
if(!peers.includes(member)){
12631263
const index = this.#rooms[roomname].members.indexOf(member)
12641264
this.#rooms[roomname].members.splice(index,1)
1265-
this.#rooms[roomname].onMembers(this.#rooms[roomname].members)
1265+
this.#rooms[roomname].onMembersUpdate(this.#rooms[roomname].members)
12661266
}
12671267
}
12681268
}
@@ -2075,8 +2075,8 @@ const createWebPEER = async (configuration) => {
20752075
}
20762076

20772077
let signalconfig = {};
2078-
if(configuration && configuration.networkName){
2079-
signalconfig['appid'] = configuration.networkName;
2078+
if(configuration && configuration.appName){
2079+
signalconfig['appid'] = configuration.appName;
20802080
}else{
20812081
signalconfig['appid'] = config.CONFIG_PREFIX;
20822082
}

test/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ <h3>Log: <span id="logCount">0</span></h3>
7878

7979

8080
const configuration = {
81-
networkName: 'testWebPEER'
81+
appName: 'testWebPEER'
8282
}
8383

8484
const node = await createWebPEER(configuration)

0 commit comments

Comments
 (0)