Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where using the display speech output braille mode while no braille display is connected causes zero division errors #17243

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Emil-18
Copy link
Contributor

@Emil-18 Emil-18 commented Oct 3, 2024

Link to issue number:

fixes #17092

Summary of the issue:

When using the display speech output braille mode with no braille display connected and the braille viewer closed, zero division errors are thrown

Description of user facing changes

The user can have braille mode set to display speech output at all times, without NVDA spamming the log file

Description of development approach

Made the showSpeechInBraille function return without doing anything if the braille.handler object is not enabled

Testing strategy:

I am unable to test it, because when I run NVDA from source it crashes. @josephsl Could you confirm that this works?

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Braille: zero division error while using "speech output" mode
1 participant