fix: address code review findings

- Pass opts.Body as --description to gt submit (was silently dropped)
- Return created/updated status from parseSubmitResult instead of
  hardcoding Created: true (uses the captured group from gt output)
- Add PR state constants to driver package, replace magic string
  "MERGED" in sync.go (reverts regression from PR #20's fix)
- Add NewNative() constructor with gh.Available() check, matching
  the pattern established by NewGraphite() for gt

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: nvandessel

cmd/sync.go

@@ -100,7 +100,7 @@ func runSync(cmd *cobra.Command, args []string) error {
 			fmt.Fprintf(os.Stderr, "warning: could not check PR #%d for %s: %v\n", *b.PR, name, err)
 			continue
 		}
-		if prState == "MERGED" {
+		if prState == driver.PRStateMerged {
 			mergedBranches = append(mergedBranches, name)
 			mergedData[name] = b
 		}

internal/driver/driver.go

@@ -56,12 +56,19 @@ func (e *RebaseConflictError) Error() string {
 	return fmt.Sprintf("rebase conflict on branch %s: %s", e.Branch, e.Detail)
 }
 
+// PR state constants returned by PRState.
+const (
+	PRStateOpen   = "OPEN"
+	PRStateClosed = "CLOSED"
+	PRStateMerged = "MERGED"
+)
+
 // Resolve returns the Driver for the given driver name.
 // An empty name resolves to the native (git+gh) driver.
 func Resolve(name string) (Driver, error) {
 	switch name {
 	case "", "native":
-		return &Native{}, nil
+		return NewNative()
 	case "graphite":
 		return NewGraphite()
 	default:

internal/driver/driver_test.go

@@ -7,6 +7,17 @@ import (
 )
 
 func TestResolveNative(t *testing.T) {
+	_, err := exec.LookPath("gh")
+	if err != nil {
+		// gh not installed — Resolve should fail with a descriptive error.
+		_, resolveErr := Resolve("")
+		if resolveErr == nil {
+			t.Fatal("Resolve('') should fail when gh is not installed")
+		}
+		t.Logf("gh not installed, Resolve error: %v (expected)", resolveErr)
+		return
+	}
+
 	drv, err := Resolve("")
 	if err != nil {
 		t.Fatalf("Resolve empty: %v", err)

internal/driver/graphite.go

@@ -50,6 +50,9 @@ func (g *Graphite) Push(ctx context.Context, opts PushOpts) (*PushResult, error)
 	if opts.Title != "" && opts.ExistingPR == nil {
 		args = append(args, "--title", opts.Title)
 	}
+	if opts.Body != "" && opts.ExistingPR == nil {
+		args = append(args, "--description", opts.Body)
+	}
 
 	out, err := runGT(ctx, args...)
 	if err != nil {
@@ -61,12 +64,12 @@ func (g *Graphite) Push(ctx context.Context, opts PushOpts) (*PushResult, error)
 		return &PushResult{PRNumber: *opts.ExistingPR, Created: false}, nil
 	}
 
-	// Parse PR number from gt submit output.
-	prNum, err := parsePRNumber(out, opts.Branch)
+	// Parse PR number and created/updated status from gt submit output.
+	prNum, created, err := parseSubmitResult(out, opts.Branch)
 	if err != nil {
 		return nil, fmt.Errorf("parsing PR number from gt submit output: %w", err)
 	}
-	return &PushResult{PRNumber: prNum, Created: true}, nil
+	return &PushResult{PRNumber: prNum, Created: created}, nil
 }
 
 func (g *Graphite) Rebase(ctx context.Context, _, _ string) error {
@@ -95,9 +98,10 @@ func runGT(ctx context.Context, args ...string) (string, error) {
 	return strings.TrimSpace(out.String()), err
 }
 
-// parsePRNumber extracts the PR number for branch from gt submit output.
+// parseSubmitResult extracts the PR number and created/updated status for
+// branch from gt submit output.
 // gt submit prints one line per branch: "<branch>: <url> (created|updated)"
-func parsePRNumber(output, branch string) (int, error) {
+func parseSubmitResult(output, branch string) (prNumber int, created bool, err error) {
 	for _, line := range strings.Split(output, "\n") {
 		line = strings.TrimSpace(line)
 		matches := submitLineRe.FindStringSubmatch(line)
@@ -110,13 +114,13 @@ func parsePRNumber(output, branch string) (int, error) {
 		url := matches[2]
 		idx := strings.LastIndex(url, "/")
 		if idx == -1 || idx == len(url)-1 {
-			return 0, fmt.Errorf("malformed PR URL %q: no trailing number", url)
+			return 0, false, fmt.Errorf("malformed PR URL %q: no trailing number", url)
 		}
-		num, err := strconv.Atoi(url[idx+1:])
-		if err != nil {
-			return 0, fmt.Errorf("malformed PR URL %q: %w", url, err)
+		num, parseErr := strconv.Atoi(url[idx+1:])
+		if parseErr != nil {
+			return 0, false, fmt.Errorf("malformed PR URL %q: %w", url, parseErr)
 		}
-		return num, nil
+		return num, matches[3] == "created", nil
 	}
-	return 0, fmt.Errorf("branch %q not found in gt submit output:\n%s", branch, output)
+	return 0, false, fmt.Errorf("branch %q not found in gt submit output:\n%s", branch, output)
 }

internal/driver/graphite_test.go

@@ -5,33 +5,37 @@ import (
 	"testing"
 )
 
-func TestParsePRNumber(t *testing.T) {
+func TestParseSubmitResult(t *testing.T) {
 	tests := []struct {
-		name    string
-		output  string
-		branch  string
-		want    int
-		wantErr string
+		name        string
+		output      string
+		branch      string
+		wantPR      int
+		wantCreated bool
+		wantErr     string
 	}{
 		{
-			name:   "created on .com domain",
-			output: "my-feature: https://app.graphite.com/github/pr/owner/repo/42 (created)",
-			branch: "my-feature",
-			want:   42,
+			name:        "created on .com domain",
+			output:      "my-feature: https://app.graphite.com/github/pr/owner/repo/42 (created)",
+			branch:      "my-feature",
+			wantPR:      42,
+			wantCreated: true,
 		},
 		{
-			name:   "updated on .dev domain",
-			output: "my-feature: https://app.graphite.dev/github/pr/owner/repo/99 (updated)",
-			branch: "my-feature",
-			want:   99,
+			name:        "updated on .dev domain",
+			output:      "my-feature: https://app.graphite.dev/github/pr/owner/repo/99 (updated)",
+			branch:      "my-feature",
+			wantPR:      99,
+			wantCreated: false,
 		},
 		{
 			name: "multi-branch stack matches correct branch",
 			output: `pp--06-14-part_1: https://app.graphite.com/github/pr/withgraphite/repo/100 (created)
 pp--06-14-part_2: https://app.graphite.com/github/pr/withgraphite/repo/101 (created)
 pp--06-14-part_3: https://app.graphite.com/github/pr/withgraphite/repo/102 (created)`,
-			branch: "pp--06-14-part_2",
-			want:   101,
+			branch:      "pp--06-14-part_2",
+			wantPR:      101,
+			wantCreated: true,
 		},
 		{
 			name:    "branch not found",
@@ -55,7 +59,7 @@ pp--06-14-part_3: https://app.graphite.com/github/pr/withgraphite/repo/102 (crea
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			got, err := parsePRNumber(tt.output, tt.branch)
+			gotPR, gotCreated, err := parseSubmitResult(tt.output, tt.branch)
 			if tt.wantErr != "" {
 				if err == nil {
 					t.Fatalf("expected error containing %q, got nil", tt.wantErr)
@@ -68,8 +72,11 @@ pp--06-14-part_3: https://app.graphite.com/github/pr/withgraphite/repo/102 (crea
 			if err != nil {
 				t.Fatalf("unexpected error: %v", err)
 			}
-			if got != tt.want {
-				t.Errorf("parsePRNumber() = %d, want %d", got, tt.want)
+			if gotPR != tt.wantPR {
+				t.Errorf("prNumber = %d, want %d", gotPR, tt.wantPR)
+			}
+			if gotCreated != tt.wantCreated {
+				t.Errorf("created = %v, want %v", gotCreated, tt.wantCreated)
 			}
 		})
 	}

internal/driver/native.go

@@ -12,6 +12,14 @@ import (
 // Native is the default driver using git + gh CLIs directly.
 type Native struct{}
 
+// NewNative validates that gh is installed and returns a Native driver.
+func NewNative() (*Native, error) {
+	if err := gh.Available(); err != nil {
+		return nil, err
+	}
+	return &Native{}, nil
+}
+
 func (n *Native) Name() string { return "native" }
 
 func (n *Native) CurrentBranch(ctx context.Context) (string, error) {