Instead of defining the destructor inline, provide its implementation in a separate source file to make GCC 13 happy in release mode.

Also fix other compilation errors in release mode.

Signed-off-by: Raju Konda <kraju@nvidia.com>

Author: krajunv

common/libs/VkCodecUtils/VkImageResource.cpp

@@ -88,6 +88,11 @@ VkImageResource::VkImageResource(const VulkanDeviceContext* vkDevCtx,
     }
 }
 
+VkImageResource::~VkImageResource()
+{
+    Destroy();
+}
+
 VkResult VkImageResource::Create(const VulkanDeviceContext* vkDevCtx,
                                  const VkImageCreateInfo* pImageCreateInfo,
                                  VkMemoryPropertyFlags memoryPropertyFlags,

common/libs/VkCodecUtils/VkImageResource.h

@@ -113,7 +113,7 @@ class VkImageResource : public VkVideoRefCountBase
 
     void Destroy();
 
-    virtual ~VkImageResource() { Destroy(); }
+    virtual ~VkImageResource();
 };
 
 class VkImageResourceView : public VkVideoRefCountBase

common/libs/VkCodecUtils/VulkanDeviceMemoryImpl.cpp

@@ -410,3 +410,8 @@ const uint8_t* VulkanDeviceMemoryImpl::GetReadOnlyDataPtr(VkDeviceSize offset, V
     maxSize = m_memoryRequirements.size - offset;
     return readData;
 }
+
+VulkanDeviceMemoryImpl::~VulkanDeviceMemoryImpl()
+{
+    Deinitialize();
+}

common/libs/VkCodecUtils/VulkanDeviceMemoryImpl.h

@@ -106,7 +106,7 @@ class VulkanDeviceMemoryImpl : public VkVideoRefCountBase
 
     void Deinitialize();
 
-    virtual ~VulkanDeviceMemoryImpl() { Deinitialize(); }
+    virtual ~VulkanDeviceMemoryImpl();
 
 private:
     std::atomic<int32_t>       m_refCount;

vk_video_decoder/libs/VkDecoderUtils/ElementaryStream.cpp

@@ -64,7 +64,12 @@ class ElementaryStream : public VideoStreamDemuxer {
 
         m_bitstreamDataSize = size;
         fseek(handle, 0, SEEK_SET);
-        fread(data, 1, size, handle);
+        size_t readBytes = fread(data, 1, size, handle);
+        if (readBytes != size) {
+            free(data);
+            fclose(handle);
+            return;
+        }
         m_pBitstreamData = data;
         fclose(handle);
 #else

vk_video_decoder/libs/VkVideoDecoder/VkVideoDecoder.cpp

@@ -960,6 +960,9 @@ int VkVideoDecoder::DecodePictureWithParameters(VkParserPerFrameDecodeParameters
 
         bool valid = pCurrFrameDecParams->pStdSps->GetClientObject(currentVkPictureParameters);
         assert(valid);
+        if (!valid) {
+            return -1;
+        }
         VkParserVideoPictureParameters* pOwnerPictureParameters =
             VkParserVideoPictureParameters::VideoPictureParametersFromBase(currentVkPictureParameters);