fix(Windows): spawn tnfsd.exe hidden; actually kill it on stop

Author: nwah

FyneApp.toml

@@ -4,5 +4,5 @@ Website = "https://fujinet.online"
   Icon = "Icon.png"
   Name = "TNFS Server Manager"
   ID = "org.fujinet.tnfs-ui"
-  Version = "0.0.1"
-  Build = 18
+  Version = "0.0.2"
+  Build = 21

internal/tnfs/process.go

@@ -0,0 +1,51 @@
+//go:build darwin || bsd || linux
+
+package tnfs
+
+import (
+	"errors"
+	"fmt"
+	"io"
+	"os/exec"
+	"syscall"
+)
+
+func (s *Server) launchSubprocess() error {
+	cmd := exec.Command(s.cfg.ExePath, s.cfg.TnfsRootPath)
+
+	errR, _ := cmd.StderrPipe()
+	outR, _ := cmd.StdoutPipe()
+	s.Log = io.MultiReader(errR, outR)
+
+	err := cmd.Start()
+	if err != nil {
+		return s.fail(err)
+	}
+	s.Process = cmd.Process
+
+	go func() {
+		err = cmd.Wait()
+		if err != nil {
+			fmt.Println(err.Error())
+			if cmd.ProcessState.ExitCode() == 255 {
+				s.fail(errors.New("TNFS port (16384) may be in use"))
+			}
+		}
+	}()
+
+	return nil
+}
+
+func (s *Server) killSubprocess() error {
+	if s.Process == nil {
+		return errors.New("Not started")
+	}
+	// TODO: timeout when killing
+	s.Process.Signal(syscall.SIGTERM)
+	_, err := s.Process.Wait()
+
+	if err != nil && !errors.Is(err, syscall.ECHILD) {
+		return s.fail(err)
+	}
+	return nil
+}

internal/tnfs/process_other.go

@@ -0,0 +1,50 @@
+//go:build windows
+
+package tnfs
+
+import (
+	"errors"
+	"fmt"
+	"io"
+	"os/exec"
+	"syscall"
+)
+
+func (s *Server) launchSubprocess() error {
+	cmd := exec.Command(s.cfg.ExePath, s.cfg.TnfsRootPath)
+	cmd.SysProcAttr = &syscall.SysProcAttr{HideWindow: true}
+
+	errR, _ := cmd.StderrPipe()
+	outR, _ := cmd.StdoutPipe()
+	s.Log = io.MultiReader(errR, outR)
+
+	err := cmd.Start()
+	if err != nil {
+		return s.fail(err)
+	}
+	s.Process = cmd.Process
+
+	go func() {
+		err = cmd.Wait()
+		if err != nil {
+			fmt.Println(err.Error())
+			if cmd.ProcessState.ExitCode() == 255 {
+				s.fail(errors.New("TNFS port (16384) may be in use"))
+			}
+		}
+	}()
+
+	return nil
+}
+
+func (s *Server) killSubprocess() error {
+	if s.Process == nil {
+		return errors.New("Not started")
+	}
+
+	if err := s.Process.Kill(); err != nil {
+		return s.fail(err)
+	}
+
+	return nil
+}

internal/tnfs/tnfs.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"io"
 	"os"
-	"os/exec"
 	"os/signal"
 	"strings"
 	"syscall"
@@ -98,46 +97,6 @@ func (s *Server) sendLogEvent(msg string) {
 	s.EventCh <- e
 }
 
-func (s *Server) launchSubprocess() error {
-	cmd := exec.Command(s.cfg.ExePath, s.cfg.TnfsRootPath)
-
-	errR, _ := cmd.StderrPipe()
-	outR, _ := cmd.StdoutPipe()
-	s.Log = io.MultiReader(errR, outR)
-
-	err := cmd.Start()
-	if err != nil {
-		return s.fail(err)
-	}
-	s.Process = cmd.Process
-
-	go func() {
-		err = cmd.Wait()
-		if err != nil {
-			fmt.Println(err.Error())
-			if cmd.ProcessState.ExitCode() == 255 {
-				s.fail(errors.New("TNFS port (16384) may be in use"))
-			}
-		}
-	}()
-
-	return nil
-}
-
-func (s *Server) killSubprocess() error {
-	if s.Process == nil {
-		return errors.New("Not started")
-	}
-	// TODO: timeout when killing
-	s.Process.Signal(syscall.SIGTERM)
-	_, err := s.Process.Wait()
-
-	if err != nil && !errors.Is(err, syscall.ECHILD) {
-		return s.fail(err)
-	}
-	return nil
-}
-
 func (s *Server) findExistingProcess() *os.Process {
 	all, err := ps.Processes()
 	if err != nil {