Skip to content

Commit 1a37f06

Browse files
author
Jialiu Lin
committed
[merge into m66]Remove the use of base::Unretained in ThreatDetail
Since ThreatDetail is already a RefCountedThreadSafe object, no need to use base::Unretained when binding it. [email protected] (cherry picked from commit b7b0550) Bug: 817724 Change-Id: I6795f5df05848c978d60796f682fd2bcf83dffa8 Reviewed-on: https://chromium-review.googlesource.com/944194 Reviewed-by: Varun Khaneja <[email protected]> Reviewed-by: Luke Z <[email protected]> Commit-Queue: Jialiu Lin <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#540591} Reviewed-on: https://chromium-review.googlesource.com/954606 Reviewed-by: Jialiu Lin <[email protected]> Cr-Commit-Position: refs/branch-heads/3359@{#84} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
1 parent 43780a5 commit 1a37f06

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

components/safe_browsing/browser/threat_details.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -558,8 +558,8 @@ void ThreatDetails::StartCollection() {
558558
// OnReceivedThreatDOMDetails will be called when the renderer replies.
559559
// TODO(mattm): In theory, if the user proceeds through the warning DOM
560560
// detail collection could be started once the page loads.
561-
web_contents()->ForEachFrame(base::BindRepeating(
562-
&ThreatDetails::RequestThreatDOMDetails, base::Unretained(this)));
561+
web_contents()->ForEachFrame(
562+
base::BindRepeating(&ThreatDetails::RequestThreatDOMDetails, this));
563563
}
564564
}
565565

@@ -568,9 +568,9 @@ void ThreatDetails::RequestThreatDOMDetails(content::RenderFrameHost* frame) {
568568
frame->GetRemoteInterfaces()->GetInterface(&threat_reporter);
569569
safe_browsing::mojom::ThreatReporter* raw_threat_report =
570570
threat_reporter.get();
571-
raw_threat_report->GetThreatDOMDetails(base::BindOnce(
572-
&ThreatDetails::OnReceivedThreatDOMDetails, base::Unretained(this),
573-
base::Passed(&threat_reporter), frame));
571+
raw_threat_report->GetThreatDOMDetails(
572+
base::BindOnce(&ThreatDetails::OnReceivedThreatDOMDetails, this,
573+
base::Passed(&threat_reporter), frame));
574574
}
575575

576576
// When the renderer is done, this is called.

0 commit comments

Comments
 (0)