[DevTools] fixed coverage in Node.js frontend

We should not check for resource tree model when inspecting Node.js
target.

[email protected]
[email protected]

(cherry picked from commit 8af9bb9)

Bug: chromium:787754
Change-Id: I04503a249acc05182524da40f83765e6ad7c37a5
Reviewed-on: https://chromium-review.googlesource.com/881468
Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531342}
Reviewed-on: https://chromium-review.googlesource.com/884729
Reviewed-by: Aleksey Kozyatinskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#74}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

Author: alexkozy

third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js

@@ -25,10 +25,12 @@ Coverage.CoverageView = class extends UI.VBox {
     this._toggleRecordButton = UI.Toolbar.createActionButton(this._toggleRecordAction);
     toolbar.appendToolbarItem(this._toggleRecordButton);
 
-    var startWithReloadAction =
-        /** @type {!UI.Action }*/ (UI.actionRegistry.action('coverage.start-with-reload'));
-    this._startWithReloadButton = UI.Toolbar.createActionButton(startWithReloadAction);
-    toolbar.appendToolbarItem(this._startWithReloadButton);
+    if (!Runtime.queryParam('nodeFrontend')) {
+      var startWithReloadAction =
+          /** @type {!UI.Action }*/ (UI.actionRegistry.action('coverage.start-with-reload'));
+      this._startWithReloadButton = UI.Toolbar.createActionButton(startWithReloadAction);
+      toolbar.appendToolbarItem(this._startWithReloadButton);
+    }
     this._clearButton = new UI.ToolbarButton(Common.UIString('Clear all'), 'largeicon-clear');
     this._clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear.bind(this));
     toolbar.appendToolbarItem(this._clearButton);
@@ -64,12 +66,17 @@ Coverage.CoverageView = class extends UI.VBox {
    */
   _buildLandingPage() {
     var recordButton = UI.createInlineButton(UI.Toolbar.createActionButton(this._toggleRecordAction));
-    var reloadButton = UI.createInlineButton(UI.Toolbar.createActionButtonForId('coverage.start-with-reload'));
     var widget = new UI.VBox();
-    var message = UI.formatLocalized(
-        'Click the record button %s to start capturing coverage.\n' +
-            'Click the reload button %s to reload and start capturing coverage.',
-        [recordButton, reloadButton]);
+    var message;
+    if (this._startWithReloadButton) {
+      var reloadButton = UI.createInlineButton(UI.Toolbar.createActionButtonForId('coverage.start-with-reload'));
+      message = UI.formatLocalized(
+          'Click the record button %s to start capturing coverage.\n' +
+              'Click the reload button %s to reload and start capturing coverage.',
+          [recordButton, reloadButton]);
+    } else {
+      message = UI.formatLocalized('Click the record button %s to start capturing coverage.', [recordButton]);
+    }
     message.classList.add('message');
     widget.contentElement.appendChild(message);
     widget.element.classList.add('landing-page');
@@ -110,25 +117,26 @@ Coverage.CoverageView = class extends UI.VBox {
     var mainTarget = SDK.targetManager.mainTarget();
     if (!mainTarget)
       return;
-    this._resourceTreeModel = /** @type {?SDK.ResourceTreeModel} */ (mainTarget.model(SDK.ResourceTreeModel));
-    if (!this._resourceTreeModel)
-      return;
     if (!this._model || reload)
       this._model = new Coverage.CoverageModel(mainTarget);
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.CoverageStarted);
     if (!this._model.start())
       return;
-    this._resourceTreeModel.addEventListener(
-        SDK.ResourceTreeModel.Events.MainFrameNavigated, this._onMainFrameNavigated, this);
+    this._resourceTreeModel = /** @type {?SDK.ResourceTreeModel} */ (mainTarget.model(SDK.ResourceTreeModel));
+    if (this._resourceTreeModel) {
+      this._resourceTreeModel.addEventListener(
+          SDK.ResourceTreeModel.Events.MainFrameNavigated, this._onMainFrameNavigated, this);
+    }
     this._decorationManager = new Coverage.CoverageDecorationManager(this._model);
     this._toggleRecordAction.setToggled(true);
     this._clearButton.setEnabled(false);
-    this._startWithReloadButton.setEnabled(false);
+    if (this._startWithReloadButton)
+      this._startWithReloadButton.setEnabled(false);
     this._filterInput.setEnabled(true);
     if (this._landingPage.isShowing())
       this._landingPage.detach();
     this._listView.show(this._coverageResultsElement);
-    if (reload)
+    if (reload && this._resourceTreeModel)
       this._resourceTreeModel.reloadPage();
     else
       this._poll();
@@ -146,13 +154,16 @@ Coverage.CoverageView = class extends UI.VBox {
       clearTimeout(this._pollTimer);
       delete this._pollTimer;
     }
-    this._resourceTreeModel.removeEventListener(
-        SDK.ResourceTreeModel.Events.MainFrameNavigated, this._onMainFrameNavigated, this);
-    this._resourceTreeModel = null;
+    if (this._resourceTreeModel) {
+      this._resourceTreeModel.removeEventListener(
+          SDK.ResourceTreeModel.Events.MainFrameNavigated, this._onMainFrameNavigated, this);
+      this._resourceTreeModel = null;
+    }
     var updatedEntries = await this._model.stop();
     this._updateViews(updatedEntries);
     this._toggleRecordAction.setToggled(false);
-    this._startWithReloadButton.setEnabled(true);
+    if (this._startWithReloadButton)
+      this._startWithReloadButton.setEnabled(true);
     this._clearButton.setEnabled(true);
   }