Skip to content

Commit 23eaedb

Browse files
yukidmyyuki3
authored andcommitted
Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()
This is the bug fixing for previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1253317 v8::HandleScope was not named. Bug: 894069 Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533 Reviewed-on: https://chromium-review.googlesource.com/c/1278548 Commit-Queue: Yuki Yamada <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#599110}(cherry picked from commit f93617e) Reviewed-on: https://chromium-review.googlesource.com/c/1283751 Cr-Commit-Position: refs/branch-heads/3578@{#51} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
1 parent 902f23d commit 23eaedb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ void JSBasedEventListener::handleEvent(
161161

162162
std::unique_ptr<SourceLocation> JSBasedEventListener::GetSourceLocation(
163163
EventTarget& target) {
164-
v8::HandleScope(GetIsolate());
164+
v8::HandleScope handle_scope(GetIsolate());
165165
v8::Local<v8::Value> effective_function = GetEffectiveFunction(target);
166166
if (effective_function->IsFunction())
167167
return SourceLocation::FromFunction(effective_function.As<v8::Function>());

0 commit comments

Comments
 (0)