Skip to content

Commit 3d3d7a4

Browse files
author
sczs
committed
[ios] Adds fixed height for SummaryPageInfo cell
[email protected] (cherry picked from commit 009890a) Bug: 879134 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie3c2b55b86c9710595c87856ce213675facac9b0 Reviewed-on: https://chromium-review.googlesource.com/1199686 Reviewed-by: Mark Cogan <[email protected]> Commit-Queue: Sergio Collazos <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#588538} Reviewed-on: https://chromium-review.googlesource.com/1208911 Reviewed-by: Sergio Collazos <[email protected]> Cr-Commit-Position: refs/branch-heads/3538@{#73} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
1 parent bbaf922 commit 3d3d7a4

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

ios/chrome/browser/ui/payments/payment_request_view_controller.mm

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535

3636
namespace {
3737
const CGFloat kFooterCellHorizontalPadding = 16;
38-
3938
const CGFloat kButtonEdgeInset = 9;
4039
const CGFloat kSeparatorEdgeInset = 14;
40+
const CGFloat kSummaryPageInfoRowHeight = 55;
4141

4242
typedef NS_ENUM(NSInteger, SectionIdentifier) {
4343
SectionIdentifierSummary = kSectionIdentifierEnumZero,
@@ -398,6 +398,13 @@ - (CGFloat)collectionView:(UICollectionView*)collectionView
398398
CollectionViewItem* item =
399399
[self.collectionViewModel itemAtIndexPath:indexPath];
400400

401+
// TODO(crbug.com/879588): Remove this when/if cr_preferredHeightForWidth
402+
// works on the next iOS 12 releases.
403+
if (@available(iOS 12, *)) {
404+
if (item.type == ItemTypeSummaryPageInfo)
405+
return kSummaryPageInfoRowHeight;
406+
}
407+
401408
UIEdgeInsets inset = [self collectionView:collectionView
402409
layout:collectionView.collectionViewLayout
403410
insetForSectionAtIndex:indexPath.section];

0 commit comments

Comments
 (0)