Skip to content

Commit 419f5d5

Browse files
author
Robert Ogden
committed
Don't use custom load original logic for LitePageRedirect
Bug: 940510 Change-Id: I376004ebb9568c5f55f123a40011a592a52e546c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515237 Commit-Queue: Robert Ogden <[email protected]> Commit-Queue: Ryan Sturm <[email protected]> Auto-Submit: Robert Ogden <[email protected]> Reviewed-by: Ryan Sturm <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#639567}(cherry picked from commit 426fd40152bb2931b7e6a086bf18071c46a8a84c) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518469 Reviewed-by: Robert Ogden <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#52} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
1 parent 8df72e3 commit 419f5d5

File tree

1 file changed

+1
-19
lines changed

1 file changed

+1
-19
lines changed

chrome/browser/previews/previews_ui_tab_helper.cc

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -98,22 +98,6 @@ bool ShouldShowUIForPreviewsType(previews::PreviewsType type) {
9898
return true;
9999
}
100100

101-
void LoadOriginalForLitePageRedirect(content::WebContents* web_contents) {
102-
std::string original_url;
103-
bool extracted = previews::ExtractOriginalURLFromLitePageRedirectURL(
104-
web_contents->GetController().GetLastCommittedEntry()->GetURL(),
105-
&original_url);
106-
ALLOW_UNUSED_LOCAL(extracted);
107-
DCHECK(extracted);
108-
content::OpenURLParams url_params(GURL(original_url), content::Referrer(),
109-
WindowOpenDisposition::CURRENT_TAB,
110-
ui::PAGE_TRANSITION_RELOAD,
111-
false /* is_render_initiated */);
112-
url_params.user_gesture = true;
113-
url_params.started_from_context_menu = false;
114-
web_contents->OpenURL(url_params);
115-
}
116-
117101
} // namespace
118102

119103
PreviewsUITabHelper::~PreviewsUITabHelper() {
@@ -240,6 +224,7 @@ void PreviewsUITabHelper::ReloadWithoutPreviews(
240224
case previews::PreviewsType::OFFLINE:
241225
case previews::PreviewsType::NOSCRIPT:
242226
case previews::PreviewsType::RESOURCE_LOADING_HINTS:
227+
case previews::PreviewsType::LITE_PAGE_REDIRECT:
243228
// Previews may cause a redirect, so we should use the original URL. The
244229
// black list prevents showing the preview again.
245230
web_contents()->GetController().Reload(
@@ -248,9 +233,6 @@ void PreviewsUITabHelper::ReloadWithoutPreviews(
248233
case previews::PreviewsType::LOFI:
249234
web_contents()->ReloadLoFiImages();
250235
break;
251-
case previews::PreviewsType::LITE_PAGE_REDIRECT:
252-
LoadOriginalForLitePageRedirect(web_contents());
253-
break;
254236
case previews::PreviewsType::NONE:
255237
case previews::PreviewsType::UNSPECIFIED:
256238
case previews::PreviewsType::LAST:

0 commit comments

Comments
 (0)