cros: Fix animation not displaying when switching between users

Only happens where there are 2+ users (ie, user list is used).

OnImageDecoded is supposed to use the animation playback type that was
set in SetAnimationEnabled. However, UpdateForUser calls SetImage which
updates image_->playback() to kFirstFrameOnly. This means that
OnImageDecoded cannot use image_->playback() as the playback type set
by SetAnimationEnabled.

[email protected]

(cherry picked from commit 484a185)

Bug: 894771
Change-Id: I47ac6daa1e8780e58abdabf59a7642ca4b9dcc43
Reviewed-on: https://chromium-review.googlesource.com/c/1277699
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599731}
Reviewed-on: https://chromium-review.googlesource.com/c/1287034
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#94}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

Author: jacobdufault-google

ash/login/ui/animated_rounded_image_view.h

@@ -49,9 +49,6 @@ class AnimatedRoundedImageView : public views::View {
   // Set playback type of the animation.
   void SetAnimationPlayback(Playback playback);
 
-  // Get the current type of animation playback.
-  Playback playback() const { return playback_; }
-
   // views::View:
   gfx::Size CalculatePreferredSize() const override;
   void OnPaint(gfx::Canvas* canvas) override;

ash/login/ui/login_user_view.cc

@@ -138,9 +138,11 @@ class LoginUserView::UserImage : public NonAccessibleView {
   }
 
   void SetAnimationEnabled(bool enable) {
+    animation_enabled_ = enable;
     image_->SetAnimationPlayback(
-        enable ? AnimatedRoundedImageView::Playback::kRepeat
-               : AnimatedRoundedImageView::Playback::kFirstFrameOnly);
+        animation_enabled_
+            ? AnimatedRoundedImageView::Playback::kRepeat
+            : AnimatedRoundedImageView::Playback::kFirstFrameOnly);
   }
 
  private:
@@ -151,14 +153,16 @@ class LoginUserView::UserImage : public NonAccessibleView {
       return;
     }
 
-    // Don't change the playback style which was set in SetAnimationEnabled.
     image_->SetAnimationDecoder(
         std::make_unique<PassthroughAnimationDecoder>(animation),
-        image_->playback());
+        animation_enabled_
+            ? AnimatedRoundedImageView::Playback::kRepeat
+            : AnimatedRoundedImageView::Playback::kFirstFrameOnly);
   }
 
   AnimatedRoundedImageView* image_ = nullptr;
-  int size_;
+  int size_ = 0;
+  bool animation_enabled_ = false;
 
   base::WeakPtrFactory<UserImage> weak_factory_{this};