DevTools: Audits2 use built-in dialog overlay

BUG=845406,847350,846607

Change-Id: Id3ed220dcaf00cfbed5ba7b02e27412eab09b219
Reviewed-on: https://chromium-review.googlesource.com/1076325
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Paul Irish <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#562528}(cherry picked from commit 3fce93a)
Reviewed-on: https://chromium-review.googlesource.com/1081069
Reviewed-by: Patrick Hulce <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#65}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

Author: patrickhulce

third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js

@@ -29,7 +29,6 @@ Audits2.Audits2Panel = class extends UI.Panel {
     this._controller.addEventListener(Audits2.Events.RequestAuditCancel, this._cancelAudit.bind(this));
 
     this._renderToolbar();
-    this.contentElement.createChild('div', 'audits2-dialog-overlay');
     this._auditResultsElement = this.contentElement.createChild('div', 'audits2-results-container');
     this._renderStartView();
 
@@ -100,6 +99,9 @@ Audits2.Audits2Panel = class extends UI.Panel {
     this._startView.show(this.contentElement);
     this._startView.setUnauditableExplanation(this._unauditableExplanation);
     this._startView.setStartButtonEnabled(!this._unauditableExplanation);
+    if (!this._unauditableExplanation)
+      this._startView.focusStartButton();
+
     this._newButton.setEnabled(false);
     this._refreshToolbarUI();
     this.setDefaultFocusedChild(this._startView);

third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js

@@ -142,6 +142,10 @@ Audits2.StartView = class extends UI.Widget {
     this.contentElement.style.overflow = 'auto';
   }
 
+  focusStartButton() {
+    this._startButton.focus();
+  }
+
   /**
    * @param {boolean} isEnabled
    */

third_party/blink/renderer/devtools/front_end/audits2/Audits2StatusView.js

@@ -23,6 +23,8 @@ Audits2.StatusView = class {
     this._scheduledFastFactTimeout = null;
 
     this._dialog = new UI.Dialog();
+    this._dialog.setDimmed(true);
+    this._dialog.setCloseOnEscape(false);
     this._dialog.setOutsideClickCallback(event => event.consume(true));
     this._render();
   }

third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css

@@ -22,6 +22,10 @@
     text-align: left;
 }
 
+.audits2-view button {
+    z-index: 10;
+}
+
 .audits2-status {
     width: 100%;
     flex: auto;

third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css

@@ -10,19 +10,6 @@
   line-height: 18px;
 }
 
-.audits2-dialog-overlay {
-  position: absolute;
-  width: 100%;
-  height: 100%;
-  display: none;
-  background: rgba(0,0,0,.3);
-  z-index: 100;
-}
-
-.in-progress .audits2-dialog-overlay {
-  display: block;
-}
-
 .audits2-start-view header {
   padding: 0 16px;
   display: flex;