Skip to content

Commit 806042f

Browse files
Clemens ArbesserStephane Zermatten
Clemens Arbesser
authored and
Stephane Zermatten
committed
[Autofill Assistant] Fixed recently introduced crash upon showing details.
This relates to http://crrev/c/1340940 , where the class of the bottombar layout was changed in autofill_assistant_sheet.xml, but not in the corresponding cast in BottomBarAnimations.java:setBottomBarHeight(). This merge request was approved here: https://bugs.chromium.org/p/chromium/issues/detail?id=911035 Bug: 806868 Change-Id: Id2bd5bf41862afe7e8425188a2fc048c478726c8 Reviewed-on: https://chromium-review.googlesource.com/c/1356981 Reviewed-by: Mathias Carlen <[email protected]> Commit-Queue: Clemens Arbesser <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#612702}(cherry picked from commit e5dcd97) Reviewed-on: https://chromium-review.googlesource.com/c/1365596 Reviewed-by: Stephane Zermatten <[email protected]> Cr-Commit-Position: refs/branch-heads/3626@{#110} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
1 parent 06f3ef1 commit 806042f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/BottomBarAnimations.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
import android.animation.Animator;
88
import android.animation.AnimatorListenerAdapter;
99
import android.animation.ValueAnimator;
10+
import android.support.design.widget.CoordinatorLayout;
1011
import android.util.DisplayMetrics;
1112
import android.util.TypedValue;
1213
import android.view.View;
1314
import android.view.ViewGroup;
14-
import android.widget.FrameLayout;
1515
import android.widget.LinearLayout;
1616

1717
import org.chromium.base.Callback;
@@ -159,8 +159,8 @@ public void hideDetails() {
159159
}
160160

161161
private void setBottomBarHeight(int targetHeight) {
162-
FrameLayout.LayoutParams layoutParams =
163-
(FrameLayout.LayoutParams) mBottomBarView.getLayoutParams();
162+
CoordinatorLayout.LayoutParams layoutParams =
163+
(CoordinatorLayout.LayoutParams) mBottomBarView.getLayoutParams();
164164
layoutParams.height = targetHeight;
165165
mBottomBarView.setLayoutParams(layoutParams);
166166
}

0 commit comments

Comments
 (0)