Skip to content

Commit 8d870a0

Browse files
author
Ian Vollick
committed
[vr] Fix shadow offsets
Gives the omnibox a soft shadow. Bug: 833375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2 Reviewed-on: https://chromium-review.googlesource.com/1014010 Commit-Queue: Christopher Grant <[email protected]> Reviewed-by: Christopher Grant <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#551010}(cherry picked from commit a9741a3) Reviewed-on: https://chromium-review.googlesource.com/1015186 Reviewed-by: Ian Vollick <[email protected]> Cr-Commit-Position: refs/branch-heads/3396@{#54} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
1 parent 6615906 commit 8d870a0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

chrome/browser/vr/ui_scene_creator.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2415,7 +2415,7 @@ void UiSceneCreator::CreateOmnibox() {
24152415
e->SetTransitionedProperties({});
24162416
y_offset += kUrlBarVerticalOffsetDMM;
24172417
}
2418-
e->SetTranslate(0, y_offset, kOmniboxShadowOffset);
2418+
e->SetTranslate(0, y_offset, -kOmniboxShadowOffset);
24192419
},
24202420
shadow.get())));
24212421

@@ -2623,6 +2623,7 @@ void UiSceneCreator::CreateOmnibox() {
26232623
omnibox_background->set_hit_testable(true);
26242624
omnibox_background->set_focusable(false);
26252625
omnibox_background->set_corner_radius(kOmniboxCornerRadiusDMM);
2626+
omnibox_background->SetTranslate(0, 0, kOmniboxShadowOffset);
26262627
VR_BIND_COLOR(model_, omnibox_background.get(),
26272628
&ColorScheme::omnibox_background, &Rect::SetColor);
26282629
omnibox_background->AddChild(std::move(omnibox_outer_layout));

0 commit comments

Comments
 (0)